Bug: the dropdown «Page Layout» on admin category page is untranslatable (and my fix)

dmitry_fedyuk · September 21, 2015, 11:08am

The dropdown «Page Layout» on admin category page is untranslatable due to Magento 2 core bug:

The options are defined in

magento/magento2/blob/444e252d40b3a5d5cca3468a9819743af8ed3513/app/code/Magento/Theme/view/frontend/layouts.xml#L9-L20


<layout id="1column">
    <label translate="true">1 column</label>
</layout>
<layout id="2columns-left">
    <label translate="true">2 columns with left bar</label>
</layout>
<layout id="2columns-right">
    <label translate="true">2 columns with right bar</label>
</layout>
<layout id="3columns">
    <label translate="true">3 columns</label>
</layout>

The wrong code is:

github.com

magento/magento2/blob/2.0.0/lib/internal/Magento/Framework/View/PageLayout/Config.php#L95-L110


/**
 * Extract configuration data from the DOM structure
 *
 * @param \DOMDocument $dom
 * @return array
 */
protected function _extractData(\DOMDocument $dom)
{
    $result = [];


    /** @var \DOMElement $layout */
    foreach ($dom->getElementsByTagName('layout') as $layout) {
        $result[$layout->getAttribute('id')] = trim($layout->nodeValue);
    }
    return $result;
}

It totally ignores translate attribute of label tag.
My fix is replace the wrong line with the code:

/** @var string $label */
$label = trim($layout->nodeValue);
if ('true' === (string)simplexml_import_dom($layout)->{'label'}['translate']) {
	$label = __($label);
}
$result[$layout->getAttribute('id')] = $label;