Bug: the setAdjustmentPositive() and setAdjustmentNegative() methods of the Creditmemo class wrongly use the Order's getGrandTotal() method instead of the getBaseGrandTotal() when an adjusment is in percent, so it lead to a wrong calculation result

dmitry_fedyuk · March 18, 2016, 6:30am

magento/magento2/blob/2.1.3/app/code/Magento/Sales/Model/Order/Creditmemo.php#L488-L506


/**
 * @param string $amount
 * @return $this
 */
public function setAdjustmentPositive($amount)
{
    $amount = trim($amount);
    if (substr($amount, -1) == '%') {
        $amount = (double)substr($amount, 0, -1);
        $amount = $this->getOrder()->getGrandTotal() * $amount / 100;
    }


    $amount = $this->priceCurrency->round($amount);
    $this->setData('base_adjustment_positive', $amount);


    $amount = $this->priceCurrency->round($amount * $this->getOrder()->getBaseToOrderRate());
    $this->setData('adjustment_positive', $amount);
    return $this;
}

https://github.com/magento/magento2/blob/2.1.3/app/code/Magento/Sales/Model/Order/Creditmemo.php#L508-L526

dmitry_fedyuk · March 18, 2016, 6:30am