Topics tagged code-quality

Topic	Replies	Views	Activity
A code from the \Magento\Catalog\Model\ResourceModel\Category::_getMaxPosition() method can be simplified from 5 lines to 1 Issues improvement , database , code-quality	0	907	January 26, 2016
Naming inconsistency: identically named method addCommitCallback() is called BEFORE a commit in the \Magento\Framework\DB\Transaction class, but AFTER a commit in the \Magento\Framework\Model\ResourceModel\AbstractResource class Issues improvement , database , db-transaction , code-quality	0	1045	January 27, 2016
The \Magento\SalesSequence\Model\Sequence::DEFAULT_PATTERN constant can be simplified Issues improvement , sales-documents-numeration , code-quality	0	1016	January 28, 2016
A logical issue in the \Magento\Ui\Component\AbstractComponent::__construct() method: the UI components are registered before their initialization UI Components improvement , ui-component , code-quality	0	969	January 4, 2016
The \Magento\Catalog\Model\Indexer\Category\AffectCache and \Magento\Catalog\Model\Indexer\Product\AffectCache have 39 lines of code each but differs by a single constant (copy/paste) Issues improvement , plugin , plugin-before , code-quality	0	885	January 7, 2016
The «Payment Gateway is unreachable at the moment. Please use another payment option.» string literal is duplicated in 2 places, propose to use a constant Issues improvement , paypal , payment , code-quality	0	2252	February 7, 2016
The XML config nodes `default\payment\<payment method>\active` with the «0» value are unnecessary and can be deleted without any impact on the system behaviour Issues improvement , payment , code-quality	0	805	February 8, 2016
The method \Magento\Sales\Block\Adminhtml\Order\Creditmemo\Create\Items::canEditQty() can be simplified Issues improvement , refund , code-quality	0	823	February 10, 2016
The \Magento\Catalog\Model\Indexer\Product\AffectCache::beforeExecute() method can be simplified by returning void instead of it's arguments Issues improvement , plugin , plugin-before , code-quality	0	1137	January 7, 2016
The method \Magento\Payment\Model\Method\AbstractMethod::canUseForCountry() can be simplified Issues improvement , payment , payment-method-interface , country , code-quality	0	1206	February 11, 2016
The method \Magento\Authorizenet\Model\Authorizenet::canUseForCurrency() can be simplified Issues improvement , payment , payment-method-interface , currency , payment-can-use , code-quality	0	1071	February 11, 2016
The \Magento\Payment\Helper\Data::getStoreMethods() method has a wrong PHPDoc type for the $methodInstance variable Issues improvement , phpdoc , payment , code-quality	0	892	February 12, 2016
The methods getData and setData of the \Magento\Ui\Component\AbstractComponent class have no any sense because they just call the inherited implementation without any modifications Issues improvement , ui-component , code-quality	0	2994	January 6, 2016
The «magento_sequence» observer is declared in the «Magento_Sales» module, but is implemented in the «Magento_SalesSequence» module Issues sales-documents-numeration , sales , improvement , observer , code-quality	0	954	January 9, 2016
The \Magento\Payment\Model\Checks\ZeroTotal::isApplicable() method can be simplified Issues improvement , payment , payment-validator , code-quality	0	998	March 5, 2016
The \Magento\Customer\Model\Attribute::afterSave() method does the same action for both conditions and so can be simplified Issues improvement , model-save , after-save , customer , customer-save , code-quality	0	1310	January 27, 2016
The $productId variable in the final_price.phtml is declared but never used Issues price , improvement , unused , code-quality	0	3123	December 25, 2015
The Magento\Framework\UrlInterface::URL_TYPE_JS constant is never used Issues unused , code-quality , improvement	0	515	June 18, 2017
The constructor of the class \Magento\Framework\View\Result\PageFactory can be shortened by using PHP 5.5 class name resolution via ::class Issues improvement , ::class , code-quality	1	1155	May 6, 2017
The constructor of the class \Magento\Framework\View\Result\LayoutFactory can be shortened by using PHP 5.5 class name resolution via ::class Issues improvement , ::class , code-quality	1	1177	May 6, 2017
Propose to make the properties of the \Magento\SalesSequence\Model\Sequence class protected instead of private, so to allow the subclasses to access them Issues improvement , sales-documents-numeration , sales , sales-document , code-quality	5	2438	December 20, 2016
The «Magento_Checkout/view/view/payment/default.js» object loads the «Magento_Customer/js/model/customer» object but never uses it Issues customer , improvement , javascript , checkout , magento_customer-js-model-customer , frontend-checkout-customer-data , unused , code-quality	1	1312	April 14, 2016
The getBillingAddressList() method of the «Magento_Customer/js/model/customer» object is never used Issues customer , magento_customer-js-model-customer , improvement , frontend-checkout-customer-data , code-quality	1	1156	April 15, 2016
The getShippingAddressList() method of the «Magento_Customer/js/model/customer» object is never used Issues customer , improvement , magento_customer-js-model-customer , frontend-checkout-customer-data , code-quality	1	1157	April 15, 2016
The setDetails() method of the «Magento_Customer/js/model/customer» object is never used Issues customer , improvement , magento_customer-js-model-customer , frontend-checkout-customer-data , code-quality	1	1227	April 15, 2016
The getDetails() method of the «Magento_Customer/js/model/customer» object is never used Issues improvement , customer , magento_customer-js-model-customer , frontend-checkout-customer-data , code-quality	1	1317	April 15, 2016
The addCustomerAddress() method of the «Magento_Customer/js/model/customer» object is never used Issues magento_customer-js-model-customer , customer , improvement , frontend-checkout-customer-data , unused , code-quality	1	1138	April 15, 2016
The setAddressAsDefaultBilling() method of the «Magento_Customer/js/model/customer» object is never used Issues magento_customer-js-model-customer , customer , improvement , frontend-checkout-customer-data , code-quality	1	1184	April 15, 2016
The setAddressAsDefaultShipping() method of the «Magento_Customer/js/model/customer» object is never used Issues magento_customer-js-model-customer , customer , improvement , frontend-checkout-customer-data , code-quality	1	1161	April 15, 2016
The «Magento\Customer\Model\Session» argument injection has no sense for the backend password reset scenario Issues improvement , password , password-reset , backend , backend-user , authentication , backend-authentication , dependency-injection , code-quality	1	1266	March 4, 2016