The \Magento\Sales\Controller\Adminhtml\Order\Creditmemo\Save::execute() method calls the \Magento\Sales\Api\CreditmemoManagementInterface::refund() with 3 parameters, but the method's signature contains only 2 parameters

dmitry_fedyuk · March 27, 2016, 8:23pm

magento/magento2/blob/9546277/app/code/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/Save.php#L102-L105


$creditmemoManagement = $this->_objectManager->create(
    'Magento\Sales\Api\CreditmemoManagementInterface'
);
$creditmemoManagement->refund($creditmemo, (bool)$data['do_offline'], !empty($data['send_email']));

The 3-rd argument !empty($data['send_email']) is never used, because the method’s signature contains only 2 parameters:

github.com

magento/magento2/blob/9546277/app/code/Magento/Sales/Api/CreditmemoManagementInterface.php#L46-L56


/**
 * Prepare creditmemo to refund and save it.
 *
 * @param \Magento\Sales\Api\Data\CreditmemoInterface $creditmemo
 * @param bool $offlineRequested
 * @return \Magento\Sales\Api\Data\CreditmemoInterface
 */
public function refund(
    \Magento\Sales\Api\Data\CreditmemoInterface $creditmemo,
    $offlineRequested = false
);

github.com

magento/magento2/blob/9546277/app/code/Magento/Sales/Model/Service/CreditmemoService.php#L127-L137


/**
 * Prepare creditmemo to refund and save it.
 *
 * @param \Magento\Sales\Api\Data\CreditmemoInterface $creditmemo
 * @param bool $offlineRequested
 * @return \Magento\Sales\Api\Data\CreditmemoInterface
 */
public function refund(
    \Magento\Sales\Api\Data\CreditmemoInterface $creditmemo,
    $offlineRequested = false
) {