BUG: the product general attributes (name, sku, price, quantity) are wrongly in "Images and Videos" section now

dmitry_fedyuk · October 4, 2015, 4:25am

Github Issue: 2016

dmitry_fedyuk · October 4, 2015, 4:32am

The wrong code is:

magento/magento2/blob/12955b1c7e43c560dc1060c136858531d403c682/app/code/Magento/Catalog/Setup/UpgradeData.php#L49-L58


$attributeGroupId = $categorySetup->getAttributeGroupId($entityTypeId, $attributeSetId, 'Images');


// update General Group
$categorySetup->updateAttributeGroup(
    $entityTypeId,
    $attributeSetId,
    $attributeGroupId,
    'attribute_group_name',
    'Images and Videos'
);

It tries to rename an attribute group with Images title to Images and Videos.
But attribute group titles are editable by admin.
Moreover, an administrator can delete standard attribute groups.
Moreover, why does the code looks for Images tab and not for Image Management tab?
Anyway, the Images attribute group could be absent.
Look at the code:

github.com

magento/magento2/blob/12955b1c7e43c560dc1060c136858531d403c682/app/code/Magento/Eav/Setup/EavSetup.php#L609-L611


if (!is_numeric($groupId)) {
    $groupId = $this->getDefaultAttributeGroupId($entityTypeId, $setId);
}

If the Images attribute group is absent then the default attribute group will be renamed to Images and Videos, and this is the bug.