Inconsistency: an attribute code maximum length validation does not conform to the database field maximum length

dmitry_fedyuk · October 10, 2015, 12:36am

Inconsistency: attribute code maximum length validation does not conform to the database field maximum length

The column attribute_code of the eav_attribute table has length of 255 characters:

magento/magento2/blob/1d97cd9ddee038c9b93c43b74c8e318702a70a33/app/code/Magento/Eav/Setup/InstallSchema.php#L642-L646


'attribute_code',
\Magento\Framework\DB\Ddl\Table::TYPE_TEXT,
255,
['nullable' => true, 'default' => null],
'Attribute Code'

But Magento 2 code wrongly limits attribute code the length to 30 characters:

github.com

magento/magento2/blob/1d97cd9ddee038c9b93c43b74c8e318702a70a33/app/code/Magento/Eav/Model/Entity/Attribute.php#L25


* @method \Magento\Eav\Model\Entity\Attribute setOption($value)
* @method \Magento\Eav\Api\Data\AttributeExtensionInterface getExtensionAttributes()
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class Attribute extends \Magento\Eav\Model\Entity\Attribute\AbstractAttribute implements
   \Magento\Framework\DataObject\IdentityInterface
{
   /**
    * Attribute code max length
    */
   const ATTRIBUTE_CODE_MAX_LENGTH = 30;


   /**
    * Cache tag
    */
   const CACHE_TAG = 'EAV_ATTRIBUTE';


   /**
    * Prefix of model events names
    *
    * @var string

github.com

magento/magento2/blob/1d97cd9ddee038c9b93c43b74c8e318702a70a33/app/code/Magento/Eav/Setup/EavSetup.php#L720-L733


$attributeCodeMaxLength = \Magento\Eav\Model\Entity\Attribute::ATTRIBUTE_CODE_MAX_LENGTH;


if (isset(
        $data['attribute_code']
    ) && !\Zend_Validate::is(
        $data['attribute_code'],
        'StringLength',
        ['max' => $attributeCodeMaxLength]
    )
) {
    throw new LocalizedException(
        __('An attribute code must be fewer than %1 characters.', $attributeCodeMaxLength)
    );
}

github.com

magento/magento2/blob/1d97cd9ddee038c9b93c43b74c8e318702a70a33/app/code/Magento/Eav/Model/Entity/Attribute.php#L236-L247


if (isset(
    $this->_data['attribute_code']
) && !\Zend_Validate::is(
    $this->_data['attribute_code'],
    'StringLength',
    ['max' => self::ATTRIBUTE_CODE_MAX_LENGTH]
)
) {
    throw new LocalizedException(
        __('An attribute code must be fewer than %1 characters.', self::ATTRIBUTE_CODE_MAX_LENGTH)
    );
}

See also another bug: The diagnostic message «An attribute code must be fewer than %1 characters.» is semantically wrong.

GitHub issue: 2073