The breadcrumbs are unnecessary shown on the frontend home page of a multistore system when another store has the home page with the same identifier (and my fix)

dmitrii_fediuk · November 11, 2015, 12:28am

The wrong condition:

magento/magento2/blob/22629abe10f9c640fe47b6081d57fedccdea8e0f/app/code/Magento/Cms/Block/Page.php#L128-L131


&& $page->getIdentifier() !== $this->_scopeConfig->getValue(
    'web/default/cms_home_page',
    ScopeInterface::SCOPE_STORE
)

The code is wrong because the $this->_scopeConfig->getValue('web/default/cms_home_page', ScopeInterface::SCOPE_STORE) expression can return not only a page identifier, but a page identifier with suffix too:

github.com

magento/magento2/blob/22629abe10f9c640fe47b6081d57fedccdea8e0f/app/code/Magento/Cms/Model/ResourceModel/Page/Collection.php#L55-L57


if (in_array($identifier, $existingIdentifiers)) {
    $data['value'] .= '|' . $item->getData('page_id');
} else {

So the wrong condition can compare, for example, the home string with the home|5 string.

My fix

Replace the wrong code with the new one:

&& $page->getIdentifier() !== explode('|', $this->_scopeConfig->getValue(
	'web/default/cms_home_page',
	ScopeInterface::SCOPE_STORE
))[0]

dmitrii_fediuk · June 1, 2017, 2:48pm

It has been fixed (in 18 month after reporting) in Magento 2.2 on 2017-05-24:
https://github.com/magento/magento2/commit/b37b3294