Performance issue: \Magento\Config\Model\Config\Structure::getTabs() does not cache its result and is called multiple times for the same result

dmitry_fedyuk · November 14, 2015, 5:26am

magento/magento2/blob/2335247d4ae2dc1e0728ee73022b0a244ccd7f4c/app/code/Magento/Config/Model/Config/Structure.php#L77-L88


public function getTabs()
{
    if (isset($this->_data['sections'])) {
        foreach ($this->_data['sections'] as $sectionId => $section) {
            if (isset($section['tab']) && $section['tab']) {
                $this->_data['tabs'][$section['tab']]['children'][$sectionId] = $section;
            }
        }
        $this->_tabIterator->setElements($this->_data['tabs'], $this->_scopeDefiner->getScope());
    }
    return $this->_tabIterator;
}

It is called from:

github.com

magento/magento2/blob/2335247d4ae2dc1e0728ee73022b0a244ccd7f4c/app/code/Magento/Config/Block/System/Config/Tabs.php#L75


 * @param array $data
 */
public function __construct(
    \Magento\Backend\Block\Template\Context $context,
    \Magento\Config\Model\Config\Structure $configStructure,
    \Magento\Backend\Helper\Data $backendHelper,
    array $data = []
) {
    $this->_backendHelper = $backendHelper;
    parent::__construct($context, $data);
    $this->_tabs = $configStructure->getTabs();


    $this->setId('system_config_tabs');
    $this->setTitle(__('Configuration'));
    $this->_currentSectionId = $this->getRequest()->getParam('section');


    $this->_backendHelper->addPageHelpUrl($this->getRequest()->getParam('section') . '/');
}


/**
 * Get all tabs

github.com

magento/magento2/blob/2335247d4ae2dc1e0728ee73022b0a244ccd7f4c/app/code/Magento/Config/Model/Config/Structure.php#L108


    return $this->getElementByPathParts(explode('/', $path));
}


/**
 * Retrieve first available section in config structure
 *
 * @return \Magento\Config\Model\Config\Structure\ElementInterface
 */
public function getFirstSection()
{
    $tabs = $this->getTabs();
    $tabs->rewind();
    /** @var $tab \Magento\Config\Model\Config\Structure\Element\Tab */
    $tab = $tabs->current();
    $tab->getChildren()->rewind();
    return $tab->getChildren()->current();
}


/**
 * Find element by path parts
 *

dmitry_fedyuk · November 16, 2015, 3:36pm

https://github.com/magento/magento2/issues/2387