Bug: the backend credit memos grid shows the refund amounts in the base currency, but they are labelled with the order currency sign

dmitrii_fediuk · January 18, 2017, 12:22pm

The bug is caused by absense of the base_currency_code column in the sales_creditmemo_grid table.

magento/magento2/blob/2.1.3/app/code/Magento/Sales/view/adminhtml/ui_component/sales_order_view_creditmemo_grid.xml#L146-L153


<column name="base_grand_total" class="Magento\Sales\Ui\Component\Listing\Column\Price">
    <argument name="data" xsi:type="array">
        <item name="config" xsi:type="array">
            <item name="filter" xsi:type="string">textRange</item>
            <item name="label" xsi:type="string" translate="true">Refunded</item>
        </item>
    </argument>
</column>

github.com

magento/magento2/blob/2.1.3/app/code/Magento/Sales/Ui/Component/Listing/Column/Price.php#L43-L65


/**
 * Prepare Data Source
 *
 * @param array $dataSource
 * @return array
 */
public function prepareDataSource(array $dataSource)
{
    if (isset($dataSource['data']['items'])) {
        foreach ($dataSource['data']['items'] as & $item) {
            $currencyCode = isset($item['base_currency_code']) ? $item['base_currency_code'] : null;
            $item[$this->getData('name')] = $this->priceFormatter->format(
                $item[$this->getData('name')],
                false,
                null,
                null,
                $currencyCode
            );
        }
    }


    return $dataSource;
}

Without the base_currency_code column the Magento\Sales\Ui\Component\Listing\Column\Price::prepareDataSource() formats the amounts in the display currency, but actually the base_grand_total value is in the base currency.

dmitrii_fediuk · January 19, 2017, 3:20am