\Magento\MediaStorage\Model\File\Storage\Synchronization::synchronize() wrongly leaves a file in the locked state in a case of an exception

dmitry_fedyuk (Dmitrii Fediuk) November 29, 2015, 3:26pm 1

https://github.com/magento/magento2/blob/2.0.0/app/code/Magento/MediaStorage/Model/File/Storage/Synchronization.php#L61-L68

The $file->unlock() call is absent in the exception block.

https://github.com/magento/magento2/issues/2586

\Magento\MediaStorage\Model\File\Storage\Synchronization::synchronize() suppresses its exceptions for a questionably reason

\Magento\MediaStorage\Model\File\Storage\Synchronization::synchronize() contains a wrong PHPDoc comment for the $file variable

\Magento\MediaStorage\Model\File\Storage\Synchronization::synchronize() duplicates the code in the try and catch blocks, propose to use a «finally» block

dmitry_fedyuk (Dmitrii Fediuk) November 29, 2015, 3:28pm 2

See also: