The second «if» condition of the \Magento\Quote\Model\Quote::getPayment() method is always true

dmitry_fedyuk · March 16, 2017, 11:45pm

Look at the \Magento\Quote\Model\Quote::getPayment() method:

magento/magento2/blob/2.1.5/app/code/Magento/Quote/Model/Quote.php#L1849-L1870


/**
 * @return \Magento\Quote\Model\Quote\Payment
 */
public function getPayment()
{
    if (null === $this->_currentPayment || !$this->_currentPayment) {
        $this->_currentPayment = $this->_quotePaymentCollectionFactory->create()
            ->setQuoteFilter($this->getId())
            ->getFirstItem();
    }
    if ($payment = $this->_currentPayment) {
        if ($this->getId()) {
            $payment->setQuote($this);
        }
        if (!$payment->isDeleted()) {
            return $payment;
        }
    }
    $payment = $this->_quotePaymentFactory->create();
    $this->addPayment($payment);
    return $payment;
}

This if condition is always true:

It is because the \Magento\Framework\Data\Collection::getFirstItem() method always returns an object, even if a collection is empty.