webservicex.net currency converter can return -1 in case of its internal failure (I saw it on 2016-01-01 while converting USD => EUR) but Magento 2 does not check for the -1 result

dmitry_fedyuk · January 1, 2016, 5:44am

magento/magento2/blob/2.0.0/app/code/Magento/Directory/Model/Currency/Import/Webservicex.php#L59-L79


try {
    $response = $this->_httpClient->setUri(
        $url
    )->setConfig(
        [
            'timeout' => $this->_scopeConfig->getValue(
                'currency/webservicex/timeout',
                \Magento\Store\Model\ScopeInterface::SCOPE_STORE
            ),
        ]
    )->request(
        'GET'
    )->getBody();


    $xml = simplexml_load_string($response, null, LIBXML_NOERROR);
    if (!$xml) {
        $this->_messages[] = __('We can\'t retrieve a rate from %1.', $url);
        return null;
    }
    return (double)$xml;
} catch (\Exception $e) {

dmitry_fedyuk · January 1, 2016, 5:45am