[PHP 7.2] My fix for «Declaration of Magento\Customer\Model\ResourceModel\Address\Attribute\Source\Country::getAllOptions() must be compatible with Magento\Eav\Model\Entity\Attribute\Source\Table::getAllOptions($withEmpty = true, $defaultValues = false)»

[dmitry_fedyuk (Dmitrii Fediuk)]

Magento\Customer\Model\ResourceModel\Address\Attribute\Source\Country::getAllOptions():

magento/magento2/blob/2.2.2/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Source/Country.php#L47-L52

Magento\Customer\Model\ResourceModel\Address\Attribute\Source\Country really inherits from Magento\Eav\Model\Entity\Attribute\Source\Table:

magento/magento2/blob/2.2.2/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Source/Country.php#L21-L21

Magento\Eav\Model\Entity\Attribute\Source\Table::getAllOptions():

magento/magento2/blob/2.2.2/app/code/Magento/Eav/Model/Entity/Attribute/Source/Table.php#L52-L59

[dmitry_fedyuk (Dmitrii Fediuk)]

The fact that PHP < 7.2 accepted this was an unintentional side-effect.

bugs.php.net/bug.php?id=75590#1512772457

[dmitry_fedyuk (Dmitrii Fediuk)]

My fix

Replace the line:

magento/magento2/blob/2.2.2/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Source/Country.php#L52-L52

with the following one:

public function getAllOptions($withEmpty = true, $defaultValues = false)

[dmitry_fedyuk (Dmitrii Fediuk)]

See also:

• [PHP 7.2] My fix for «Declaration of Magento\Customer\Model\ResourceModel\Address\Attribute\Source\CountryWithWebsites::getAllOptions() must be compatible with Magento\Eav\Model\Entity\Attribute\Source\Table::getAllOptions($withEmpty = true, $defaultValues = false)».
• [PHP 7.2] My fix for «Declaration of Magento\Customer\Model\ResourceModel\Address\Attribute\Source\Region::getAllOptions() must be compatible with Magento\Eav\Model\Entity\Attribute\Source\Table::getAllOptions($withEmpty = true, $defaultValues = false)».
• [PHP 7.2] My fix for «Declaration of Magento\Customer\Model\Customer\Attribute\Source\Website::getAllOptions() must be compatible with Magento\Eav\Model\Entity\Attribute\Source\Table::getAllOptions($withEmpty = true, $defaultValues = false)».
• [PHP 7.2] My fix for «Declaration of Magento\Customer\Model\Customer\Attribute\Source\Store::getAllOptions() must be compatible with Magento\Eav\Model\Entity\Attribute\Source\Table::getAllOptions($withEmpty = true, $defaultValues = false)».
• [PHP 7.2] My fix for «Declaration of Magento\Customer\Model\Customer\Attribute\Source\Group::getAllOptions() must be compatible with Magento\Eav\Model\Entity\Attribute\Source\Table::getAllOptions($withEmpty = true, $defaultValues = false)».
• [PHP 7.2] My fix for «Declaration of Magento\Eav\Model\Entity\Attribute\Source\Store::getAllOptions() must be compatible with Magento\Eav\Model\Entity\Attribute\Source\Table::getAllOptions($withEmpty = true, $defaultValues = false)».
• [PHP 7.2] My fix for «Declaration of Magento\Directory\Model\Config\Source\Country\Full::toOptionArray($isMultiselect = false) must be compatible with Magento\Directory\Model\Config\Source\Country::toOptionArray($isMultiselect = false, $foregroundCountries = '')».
• [PHP 7.2] My fix for «Declaration of Magento\Tax\Model\System\Config\Source\Tax\Country::toOptionArray($noEmpty = false) must be compatible with Magento\Directory\Model\Config\Source\Country::toOptionArray($isMultiselect = false, $foregroundCountries = '')».