The beforeSave() method in app/code/Magento/Ui/view/base/web/js/form/client.js tries to make AJAX requests for undefined URLs

dmitrii_fediuk · February 2, 2016, 11:36am

magento/magento2/blob/c53d060/app/code/Magento/Ui/view/base/web/js/form/client.js#L13-L33


function beforeSave(data, url) {
    var save = $.Deferred();


    data = utils.serialize(data);


    data.form_key = window.FORM_KEY;


    if (!url) {
        save.resolve();
    }


    $('body').trigger('processStart');


    $.ajax({
        url: url,
        data: data,
        success: function (resp) {
            if (!resp.error) {
                save.resolve();
                return true;
            }

Loot at the code:

url could be "undefined" string, not the undefined global variable nor null literal, so the condition will be true in this case, and the system will try to do an AJAX request with undefined URL.

The error is strongly related to another error: The template() function in lib/web/mage/utils/template.js returns «undefined» values as a string, not as the undefined global variable nor null literal, which lead to mistakes in the core code’s logical expressions