How did I upgrade tradefurniturecompany.co.uk from Magento 2.3.2 to 2.3.6-p1?

dmitry_fedyuk · June 29, 2023, 9:13pm

Step 1

bin/magento maintenance:enable

Step 2

I replaced the the root’s composer.json file with the file from Magento 2.3.6-p1.
Then I declared already installed third-party packages in the require section of the file:

github.com

tradefurniturecompany/site/blob/2023-06-30-1/composer.json#L17-L36


      
          "require": {
              "magento/product-community-edition": "2.3.6-p1",
              "magento/composer-root-update-plugin": "~1.0",
              "amasty/base": "1.12.9",
              "amasty/feed": "*",
              "elgentos/regenerate-catalog-urls": "*",
              "fishpig/magento2-wordpress-integration": "*",
              "fishpig/magento2-wordpress-integration-yoastseo": "*",
              "mageplaza/module-core": "^1.3",
              "mailchimp/mc-magento2": "*",
              "olegkoval/magento2-regenerate-url-rewrites": "*",
              "realexpayments/hpp": "*",
              "tradefurniturecompany/blog": "*",
              "tradefurniturecompany/core": "*",
              "tradefurniturecompany/google-shopping": "*",
              "tradefurniturecompany/image": "*",
              "tradefurniturecompany/realex": "*",
              "tradefurniturecompany/report": "*",
              "yireo/magento2-disablelog2": "*"
          },

Step 3

composer require mailchimp/mc-magento2:102.3.*

It fixes the error

Step 4

rm -rf composer.lock
composer update

Step 5

Then I restored patches in Magento files (which have been overwritten by composer update).

5.1. `lib/web/fotorama/fotorama.js`

github.com

tradefurniturecompany/site/blob/2023-06-30-1/lib/web/fotorama/fotorama.js#L1422-L1429


      
          			/**
          			 * 2019-09-19 Dmitry Fedyuk https://www.upwork.com/fl/mage2pro
          			 * 1) «Provide a way to enlarge product images on frontend product pages»:
          			 * https://github.com/tradefurniturecompany/core/issues/2
          			 * 2) The original code is:
          			 * 	`tolerance = (tail.noMove || tail.noSwipe || controlTouch) ? 16 : !tail.snap ? 4 : 0`
          			 */
                      tolerance = tail.noMove || tail.noSwipe || controlTouch ? 16 : 4;

github.com/tradefurniturecompany/core

Provide a way to enlarge product images on frontend product pages

opened 08:55AM - 19 Sep 19 UTC

closed 02:28PM - 20 Sep 19 UTC

dmitrii-fediuk

enhancement

[upwork.com/messages/rooms/room_8e141f0c39ea3e5091cd334db37aaef0/story_7085fd0a6…104307a50f6278dc98372e3](https://www.upwork.com/messages/rooms/room_8e141f0c39ea3e5091cd334db37aaef0/story_7085fd0a6104307a50f6278dc98372e3) > Not working when I tap on to it ![Screenshot_20190919-070721_Chrome](https://user-images.githubusercontent.com/83204/65229130-909fb200-daed-11e9-9942-3599e2c02d35.jpg)

5.2. `pub/errors/default/503.phtml`

github.com

tradefurniturecompany/site/blob/2023-06-30-1/pub/errors/default/503.phtml#L8-L8


      
          <h1>sorry our site is currently under maintenance and will be back online soon, for any enquiries please call 0330 8084447</h1>

5.3. `vendor/magento/framework/Stdlib/Cookie/PhpCookieManager.php`

github.com

tradefurniturecompany/site/blob/2023-06-30-1/vendor/magento/framework/Stdlib/Cookie/PhpCookieManager.php#L215-L221


      
                  	# 2020-10-22 Dmitry Fedyuk https://www.upwork.com/fl/mage2pro
          			# 1) «Unable to send the cookie. Size of 'mage-messages' is <…> bytes.»
          			# https://github.com/tradefurniturecompany/site/issues/186
          			# 2) https://magento.stackexchange.com/a/292945
          			# 3) https://magento.stackexchange.com/a/314402
          			# 4) https://magento.stackexchange.com/a/307744
                  	df_log_l($this, ['name' => $name, 'size' => $sizeOfCookie, 'value' => $value]);

github.com/tradefurniturecompany/site

«Unable to send the cookie. Size of 'mage-messages' is <…> bytes.»

opened 10:59PM - 21 Oct 20 UTC

dmitrii-fediuk

``` /customer/account/loginpost/referer/ahr0chm6ly93d3cudhjhzgvmdxjuaxr1cmvjb21…wyw55lmnvlnvrl2jsb2cvynv5zxjzlwd1awrlcw%2c%2c/ ``` ``` #1 Magento\Framework\Stdlib\Cookie\PhpCookieManager->setCookie() called at [vendor/magento/framework/Stdlib/Cookie/PhpCookieManager.php:121] #2 Magento\Framework\Stdlib\Cookie\PhpCookieManager->setPublicCookie() called at [vendor/magento/module-theme/Controller/Result/MessagePlugin.php:140] #3 Magento\Theme\Controller\Result\MessagePlugin->setCookie() called at [vendor/magento/module-theme/Controller/Result/MessagePlugin.php:95] #4 Magento\Theme\Controller\Result\MessagePlugin->afterRenderResult() called at [vendor/magento/framework/Interception/Interceptor.php:146] #5 Magento\Framework\Controller\Result\Redirect\Interceptor->Magento\Framework\Interception\{closure}() called at [vendor/magento/framework/Interception/Interceptor.php:153] #6 Magento\Framework\Controller\Result\Redirect\Interceptor->___callPlugins() called at [generated/code/Magento/Framework/Controller/Result/Redirect/Interceptor.php:26] #7 Magento\Framework\Controller\Result\Redirect\Interceptor->renderResult() called at [vendor/magento/framework/App/Http.php:141] #8 Magento\Framework\App\Http->launch() called at [vendor/magento/framework/App/Bootstrap.php:261] #9 Magento\Framework\App\Bootstrap->run() called at [pub/index.php:40] ```

5.4. `vendor/magento/framework/View/Element/Template/File/Validator.php`

github.com

tradefurniturecompany/site/blob/2.3.6-v3/vendor/magento/framework/View/Element/Template/File/Validator.php#L138-L144


      
                  $realPath = $this->fileDriver->getRealPath($path);
          		// 2019-10-06 Dmitry Fedyuk https://www.upwork.com/fl/mage2pro
          		// How to fix the «Invalid template file» / «require_js.phtml» failure of Magento 2.3.x in Windows?
          		// https://mage2.pro/t/5774
          		$isWin = 'WIN' === strtoupper(substr(PHP_OS, 0, 3)); /** @var bool $isWin */
          		foreach ($directories as $directory) {
          			if (0 === strpos($realPath, !$isWin ? $directory : str_replace('/', DIRECTORY_SEPARATOR, $directory))) {

How to fix the «Invalid template file» / «require_js.phtml» failure for 2.3 ≤ Magento < 2.4.5 in Windows?

5.5. `vendor/magento/module-paypal/Model/Api/Nvp.php`

github.com

tradefurniturecompany/site/blob/2023-06-30-1/vendor/magento/module-paypal/Model/Api/Nvp.php#L1240-L1264


      
          		/**
          		 * 2020-02-18 Dmitry Fedyuk https://www.upwork.com/fl/mage2pro
          		 * "«PayPal gateway has rejected request.
          		 * You do not have permissions to make this API call» / «#10002: Authentication/Authorization Failed»":
          		 * https://github.com/tradefurniturecompany/site/issues/18
          		 */
                  $errors = $this->_extractErrorsFromResponse($response);
                  if ($errors) {
          			/**
          			 * 2020-06-24 Dmitry Fedyuk https://www.upwork.com/fl/mage2pro
          			 * I skip logging the
          			 * "[PayPal 10486] «This transaction couldn't be completed. Please redirect your customer to PayPal»"
          			 * error because it is not a bug:
          			 * https://github.com/tradefurniturecompany/site/issues/170#issuecomment-647866496
          			 * https://github.com/mage2pro/core/issues/100
          			 * 2020-08-30
          			 * "PayPal responds on `GetExpressCheckoutDetails` with the error 10002
          			 * («You do not have permissions to make this API call»)": https://github.com/tradefurniturecompany/site/issues/179
          			 */
          			if (!in_array(intval(dfa(df_first($errors), 'code')), [10002, 10486]) || 1 !== count($errors)) {

This file has been truncated. show original

github.com/tradefurniturecompany/site

PayPal responds on `GetExpressCheckoutDetails` with the error 10002 («You do not have permissions to make this API call»)

opened 11:46AM - 30 Aug 20 UTC

closed 12:35PM - 30 Aug 20 UTC

dmitrii-fediuk

Similar to https://github.com/tradefurniturecompany/site/issues/18 ```json {… "errors": [ { "code": "10002", "message": "You do not have permissions to make this API call (#10002: Authentication/Authorization Failed)." } ], "Mage2.PRO": { "mage2pro/core": "6.7.5", "Magento": "2.3.2", "PHP": "7.1.32", "Referer": "https://www.paypal.com/webapps/hermes?flow=1-P&ulReturn=true&token=EC-60B94231WT913422M&useraction=commit&country.x=GB&locale.x=en_GB", "URL": "https://www.tradefurniturecompany.co.uk/paypal/express/return/?token=EC-60B94231WT913422M&PayerID=BP4A7L9XRNAG6" }, "request": { "BUTTONSOURCE": "Magento_Cart_Community", "METHOD": "GetExpressCheckoutDetails", "SUBJECT": "paypal@furnituretrade.co.uk", "TOKEN": "EC-60B94231WT913422M", "VERSION": "72.0" }, "response": { "ACK": "Failure", "BUILD": "54737185", "CORRELATIONID": "f92198b5bec6d", "L_ERRORCODE0": "10002", "L_LONGMESSAGE0": "You do not have permissions to make this API call", "L_SEVERITYCODE0": "Error", "L_SHORTMESSAGE0": "Authentication/Authorization Failed", "TIMESTAMP": "2020-07-22T11:24:13Z", "VERSION": "72.0" } } ``` ``` Location: vendor/magento/module-paypal/Model/Api/Nvp.php:1259 Callee: df_log_l *****************1****************** Location: vendor/magento/module-paypal/Model/Api/Nvp.php:845 Callee: Magento\Paypal\Model\Api\Nvp::call *****************2****************** Location: vendor/magento/module-paypal/Model/Express/Checkout.php:619 Callee: Magento\Paypal\Model\Api\Nvp::callGetExpressCheckoutDetails *****************3****************** Location: vendor/magento/module-paypal/Controller/Express/AbstractExpress/ReturnAction.php:32 Callee: Magento\Paypal\Model\Express\Checkout::returnFromPaypal *****************4****************** Location: vendor/magento/framework/Interception/Interceptor.php:58 Callee: Magento\Paypal\Controller\Express\AbstractExpress\ReturnAction::execute *****************5****************** Location: vendor/magento/framework/Interception/Interceptor.php:138 Callee: Magento\Paypal\Controller\Express\ReturnAction::___callParent *****************6****************** Location: vendor/magento/framework/Interception/Interceptor.php:153 Callee: Magento\Paypal\Controller\Express\ReturnAction::Magento\Framework\Interception\{closure} *****************7****************** Location: generated/code/Magento/Paypal/Controller/Express/ReturnAction/Interceptor.php:26 Callee: Magento\Paypal\Controller\Express\ReturnAction::___callPlugins *****************8****************** Location: vendor/magento/framework/App/Action/Action.php:108 Callee: Magento\Paypal\Controller\Express\ReturnAction::execute *****************9****************** Location: vendor/magento/framework/Interception/Interceptor.php:58 Callee: Magento\Framework\App\Action\Action::dispatch *****************10***************** Location: vendor/magento/framework/Interception/Interceptor.php:138 Callee: Magento\Paypal\Controller\Express\ReturnAction::___callParent *****************11***************** Location: vendor/magento/framework/Interception/Interceptor.php:153 Callee: Magento\Paypal\Controller\Express\ReturnAction::Magento\Framework\Interception\{closure} *****************12***************** Location: generated/code/Magento/Paypal/Controller/Express/ReturnAction/Interceptor.php:39 Callee: Magento\Paypal\Controller\Express\ReturnAction::___callPlugins *****************13***************** Location: vendor/magento/framework/App/FrontController.php:159 Callee: Magento\Paypal\Controller\Express\ReturnAction::dispatch *****************14***************** Location: vendor/magento/framework/App/FrontController.php:99 Callee: Magento\Framework\App\FrontController::processRequest *****************15***************** Location: vendor/magento/framework/Interception/Interceptor.php:58 Callee: Magento\Framework\App\FrontController::dispatch *****************16***************** Location: vendor/magento/framework/Interception/Interceptor.php:138 Callee: Magento\Framework\App\FrontController::___callParent *****************17***************** Location: vendor/magento/module-store/App/FrontController/Plugin/RequestPreprocessor.php:94 Callee: Magento\Framework\App\FrontController::Magento\Framework\Interception\{closure} *****************18***************** Location: vendor/magento/framework/Interception/Interceptor.php:135 Callee: Magento\Store\App\FrontController\Plugin\RequestPreprocessor::aroundDispatch *****************19***************** Location: vendor/magento/module-page-cache/Model/App/FrontController/BuiltinPlugin.php:73 Callee: Magento\Framework\App\FrontController::Magento\Framework\Interception\{closure} *****************20***************** Location: vendor/magento/framework/Interception/Interceptor.php:135 Callee: Magento\PageCache\Model\App\FrontController\BuiltinPlugin::aroundDispatch *****************21***************** Location: vendor/magento/framework/Interception/Interceptor.php:153 Callee: Magento\Framework\App\FrontController::Magento\Framework\Interception\{closure} *****************22***************** Location: generated/code/Magento/Framework/App/FrontController/Interceptor.php:26 Callee: Magento\Framework\App\FrontController::___callPlugins *****************23***************** Location: vendor/magento/framework/App/Http.php:137 Callee: Magento\Framework\App\FrontController::dispatch *****************24***************** Location: vendor/magento/framework/App/Bootstrap.php:261 Callee: Magento\Framework\App\Http::launch *****************25***************** Location: pub/index.php:40 Callee: Magento\Framework\App\Bootstrap::run ```

5.6. `vendor/magento/module-quote/Model/ChangeQuoteControl.php`

github.com

tradefurniturecompany/site/blob/2023-06-30-1/vendor/magento/module-quote/Model/ChangeQuoteControl.php#L52-L58


      
                  # 2020-06-30 Dmitry Fedyuk https://www.upwork.com/fl/mage2pro
          		# «Invalid state change requested
          		# at vendor/magento/module-quote/Model/QuoteRepository/Plugin/AccessChangeQuoteControl.php:45»:
          		# https://github.com/tradefurniturecompany/site/issues/171
          		if (!$isAllowed) {
          			df_log_l($this, ['getCustomerId' => $quote->getCustomerId(), 'getUserType' => $this->userContext->getUserType()]);
          		}

Step 6

github.com

tradefurniturecompany/site/blob/2.3.6/vendor/magento/framework/Session/SessionManager.php#L624-L626


      
          if ($option=='session.save_handler') {
              continue;
          } else {

It fixes the error:

Step 7

github.com

tradefurniturecompany/site/blob/2.3.6-v2/vendor/magento/framework/Image/Adapter/Gd2.php#L90-L92


      
          		# 2023-06-30 Dmitrii Fediuk https://www.upwork.com/fl/mage2pro
          		# "Fix product images for Magento ≥ 2.3.5 in Windows": https://github.com/tradefurniturecompany/site/issues/248
                  if ($url && isset($url['scheme']) && !in_array($url['scheme'], $allowed_schemes) && !file_exists($filename)) {

How to fix product images in Magento ≥ 2.3.5 in Windows?

Step 8

github.com/tradefurniturecompany/site

The «Add to basket» button is wrongly shifted up in Magento 2.3.6 on frontend product list pages

opened 02:32PM - 30 Jun 23 UTC

closed 03:44PM - 30 Jun 23 UTC

dmitrii-fediuk

bug magento-2.3.6

[tradefurniturecompany.co.uk/more-collections/mango-light](https://www.tradefurn…iturecompany.co.uk/more-collections/mango-light) Caused by https://github.com/tradefurniturecompany/site/issues/244 ![2023-06-30--17-29-53](https://github.com/tradefurniturecompany/site/assets/83204/4960b8f0-b508-4b45-9fa8-b7c95bf93c55)

Step 9

Step 10

Step 11

bin/magento setup:upgrade
bin/magento cache:enable

Step 12

I disabled the preinstalled Magento’s crapware:

bin/magento module:disable Dotdigitalgroup_Chat
bin/magento module:disable Magento_NewRelicReporting
bin/magento module:disable Magento_Signifyd
bin/magento module:disable Vertex_AddressValidation
bin/magento module:disable Yotpo_Yotpo

Step 13

rm -rf var/di var/generation generated/*
bin/magento setup:di:compile
bin/magento cache:clean
rm -rf pub/static/* var/cache var/page_cache var/view_preprocessed
bin/magento setup:static-content:deploy \
	--area adminhtml \
	--theme Magento/backend \
	-f en_US en_GB
bin/magento setup:static-content:deploy \
	--area frontend \
	--theme TradeFurnitureCompany/default \
	-f en_GB
bin/magento cache:clean
bin/magento maintenance:disable

dmitry_fedyuk · July 2, 2023, 11:05pm

How did I upgrade tradefurniturecompany.co.uk from Magento 2.3.6-p1 to 2.3.7-p4?

Step 1

Step 2

Step 3

Step 4

Step 5

5.1. lib/web/fotorama/fotorama.js

5.2. pub/errors/default/503.phtml

5.3. vendor/magento/framework/Stdlib/Cookie/PhpCookieManager.php

5.4. vendor/magento/framework/View/Element/Template/File/Validator.php

5.5. vendor/magento/module-paypal/Model/Api/Nvp.php

5.6. vendor/magento/module-quote/Model/ChangeQuoteControl.php

Step 6

Step 7

Step 8

Step 9

Step 10

Step 11

Step 12

Step 13

5.1. `lib/web/fotorama/fotorama.js`

5.2. `pub/errors/default/503.phtml`

5.3. `vendor/magento/framework/Stdlib/Cookie/PhpCookieManager.php`

5.4. `vendor/magento/framework/View/Element/Template/File/Validator.php`

5.5. `vendor/magento/module-paypal/Model/Api/Nvp.php`

5.6. `vendor/magento/module-quote/Model/ChangeQuoteControl.php`