Magento does not pass the values of missed optional arguments of intercepted methods to plugins

dmitry_fedyuk · August 5, 2023, 9:39pm

1.

For a method NAME Magento generates the interceptor code:

public function NAME(<…>) {
	$pluginInfo = $this->pluginList->getNext($this->subjectType, 'NAME');
	return $pluginInfo ? $this->___callPlugins('NAME', func_get_args(), $pluginInfo) : parent::NAME($i);
}

Let’s see \Magento\Framework\Pricing\Render\Amount::formatCurrency() as an example:

github.com

magento/magento2/blob/2.4.7-beta1/lib/internal/Magento/Framework/Pricing/Render/Amount.php#L214-L228


      
          /**
           * Format price value
           *
           * @param float $amount
           * @param bool $includeContainer
           * @param int $precision
           * @return float
           */
          public function formatCurrency(
              $amount,
              $includeContainer = true,
              $precision = PriceCurrencyInterface::DEFAULT_PRECISION
          ) {
              return $this->priceCurrency->format($amount, $includeContainer, $precision);
          }

Magento generates the interceptor method \Magento\Framework\Pricing\Render\Amount\Interceptor::formatCurrency() with the code:

public function formatCurrency($amount, $includeContainer = true, $precision = 2) {
	$pluginInfo = $this->pluginList->getNext($this->subjectType, 'formatCurrency');
	return $pluginInfo ? $this->___callPlugins('formatCurrency', func_get_args(), $pluginInfo) : parent::formatCurrency($amount, $includeContainer, $precision);
}

2.

func_get_args does not return the values of missed optional arguments:

3v4l.org/mLuXJ
https://www.php.net/manual/en/function.func-get-args.php#107040

3.

So if an optional argument is missed from an intercepted method call, then before- and around- plugins will not get the argument’s value.