How did I fix «strtotime() expects parameter 1 to be string, null given in vendor/magento/module-security/Model/AdminSessionInfo.php:136»?

dmitrii_fediuk · December 10, 2023, 6:41am

«strtotime() expects parameter 1 to be string, null given in vendor/magento/module-security/Model/AdminSessionInfo.php:136»

opened 06:32AM - 10 Dec 23 UTC

bug

It causes https://github.com/cabinetsbay/site/issues/6 ``` [ Mage2.PRO: { … "mage2pro/core": "10.4.8", "Magento": "2.4.4", "PHP": "7.4.33", "URL": "https://cabinetsbay.com/qyBnTg3ONvZMrIx", "Time": "2023-12-10 06:24:07", "Referer": "", "IP Address": "178.246.185.229", "Request Method": "GET", "User-Agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/119.0.0.0 Safari/537.36" } channel: main context: [] datetime: Monolog\DateTimeImmutable "2023-12-10T06:24:07.408008+00:00" extra: [] level: 500 level_name: CRITICAL message: TypeError: strtotime() expects parameter 1 to be string, null given in vendor/magento/module-security/Model/AdminSessionInfo.php:136 Stack trace: #0 vendor/magento/module-security/Model/AdminSessionInfo.php(136): strtotime() #1 vendor/magento/module-security/Model/AdminSessionInfo.php(119): Magento\Security\Model\AdminSessionInfo->isSessionExpired() #2 vendor/magento/module-security/Model/AdminSessionInfo.php(108): Magento\Security\Model\AdminSessionInfo->checkActivity() #3 vendor/magento/module-security/Model/Plugin/AuthSession.php(74): Magento\Security\Model\AdminSessionInfo->isLoggedInStatus() #4 vendor/magento/framework/Interception/Interceptor.php(135): Magento\Security\Model\Plugin\AuthSession->aroundProlong() #5 vendor/magento/module-admin-adobe-ims/Plugin/BackendAuthSessionPlugin.php(76): Magento\Backend\Model\Auth\Session\Interceptor->Magento\Framework\Interception\{closure}() #6 vendor/magento/framework/Interception/Interceptor.php(135): Magento\AdminAdobeIms\Plugin\BackendAuthSessionPlugin->aroundProlong() #7 vendor/magento/framework/Interception/Interceptor.php(153): Magento\Backend\Model\Auth\Session\Interceptor->Magento\Framework\Interception\{closure}() #8 generated/code/Magento/Backend/Model/Auth/Session/Interceptor.php(50): Magento\Backend\Model\Auth\Session\Interceptor->___callPlugins() #9 vendor/magento/module-backend/App/Action/Plugin/Authentication.php(129): Magento\Backend\Model\Auth\Session\Interceptor->prolong() #10 vendor/magento/framework/Interception/Interceptor.php(135): Magento\Backend\App\Action\Plugin\Authentication->aroundDispatch() #11 vendor/magento/framework/Interception/Interceptor.php(153): Magento\Backend\Controller\Adminhtml\Index\Index\Interceptor->Magento\Framework\Interception\{closure}() #12 generated/code/Magento/Backend/Controller/Adminhtml/Index/Index/Interceptor.php(32): Magento\Backend\Controller\Adminhtml\Index\Index\Interceptor->___callPlugins() #13 vendor/magento/framework/App/FrontController.php(245): Magento\Backend\Controller\Adminhtml\Index\Index\Interceptor->dispatch() #14 vendor/magento/framework/App/FrontController.php(212): Magento\Framework\App\FrontController->getActionResponse() #15 vendor/magento/framework/App/FrontController.php(147): Magento\Framework\App\FrontController->processRequest() #16 vendor/magento/framework/Interception/Interceptor.php(58): Magento\Framework\App\FrontController->dispatch() #17 vendor/magento/framework/Interception/Interceptor.php(138): Magento\Framework\App\FrontController\Interceptor->___callParent() #18 vendor/magento/framework/Interception/Interceptor.php(153): Magento\Framework\App\FrontController\Interceptor->Magento\Framework\Interception\{closure}() #19 generated/code/Magento/Framework/App/FrontController/Interceptor.php(23): Magento\Framework\App\FrontController\Interceptor->___callPlugins() #20 vendor/magento/framework/App/Http.php(116): Magento\Framework\App\FrontController\Interceptor->dispatch() #21 vendor/magento/framework/Interception/Interceptor.php(58): Magento\Framework\App\Http->launch() #22 vendor/magento/framework/Interception/Interceptor.php(138): Magento\Framework\App\Http\Interceptor->___callParent() #23 vendor/mage2pro/core/Framework/Plugin/App/Http.php(10): Magento\Framework\App\Http\Interceptor->Magento\Framework\Interception\{closure}() #24 vendor/magento/framework/Interception/Interceptor.php(135): Df\Framework\Plugin\App\Http->aroundLaunch() #25 vendor/magento/framework/Interception/Interceptor.php(153): Magento\Framework\App\Http\Interceptor->Magento\Framework\Interception\{closure}() #26 generated/code/Magento/Framework/App/Http/Interceptor.php(23): Magento\Framework\App\Http\Interceptor->___callPlugins() #27 vendor/magento/framework/App/Bootstrap.php(264): Magento\Framework\App\Http\Interceptor->launch() #28 pub/index.php(30): Magento\Framework\App\Bootstrap->run() #29 {main} ] 1 Df\Framework\Log\Dispatcher::handle https://github.com/mage2pro/core/tree/10.4.8/Framework/Log/Dispatcher.php#L88 2 Monolog\Logger::addRecord vendor/monolog/monolog/src/Monolog/Logger.php:399 3 Monolog\Logger::critical vendor/monolog/monolog/src/Monolog/Logger.php:663 4 Magento\Framework\Logger\LoggerProxy::critical https://github.com/magento/magento2/tree/2.4.4/lib/internal/Magento/Framework/Logger/LoggerProxy.php#L118 5 Magento\Framework\App\Bootstrap::terminate https://github.com/magento/magento2/tree/2.4.4/lib/internal/Magento/Framework/App/Bootstrap.php#L445 6 Magento\Framework\App\Bootstrap::run https://github.com/magento/magento2/tree/2.4.4/lib/internal/Magento/Framework/App/Bootstrap.php#L275 ```

github.com/magento/magento2

M 2.4.3-p1 - TypeError in AdminSessionsManager.php:338 (strtotime() expects parameter 1 to be string, int given)

opened 06:11PM - 24 Oct 21 UTC

closed 04:05PM - 01 Feb 22 UTC

simonmaass

Issue: Confirmed Reproduced on 2.4.x Priority: P1 Severity: S1 Progress: done Issue: ready for confirmation Reported on 2.4.x Area: Framework Area: Security Reported on 2.4.3-p1

### Preconditions (*)  1. Magento 2.4.3-p1 ### Steps to reproduce (*)  1. When I try to login with SSO... ### Expected result (*) 1. Login works ### Actual result (*) ``` TypeError: strtotime() expects parameter 1 to be string, int given #28 /var/www/share/meevo.io/releases/66/vendor/magento/module-security/Model/AdminSessionsManager.php(338): strtotime ``` magento2/app/code/Magento/Security/Model/AdminSessionsManager.php ``` private function lastProlongIsOldEnough() { $lastProlongTimestamp = strtotime($this->getCurrentSession()->getUpdatedAt()); $nowTimestamp = $this->authSession->getUpdatedAt(); $diff = $nowTimestamp - $lastProlongTimestamp; return (float) $diff > $this->getIntervalBetweenConsecutiveProlongs(); } ``` In this file the line https://github.com/magento/magento2/compare/2.4.3...2.4.3-p1#diff-24fbc4a93c8c25f9ee036f3bf353c3dfca22ee7ff35d0797b6d1c1d7dc012386R6 declare(strict_types=1); $this->getCurrentSession()->getUpdatedAt() returns int as timestamp... for example 1635087142 Here is the complete trace ``` TypeError: strtotime() expects parameter 1 to be string, int given #28 /vendor/magento/module-security/Model/AdminSessionsManager.php(338): strtotime #27 /vendor/magento/module-security/Model/AdminSessionsManager.php(338): Magento\Security\Model\AdminSessionsManager::lastProlongIsOldEnough #26 /vendor/magento/module-security/Model/AdminSessionsManager.php(137): Magento\Security\Model\AdminSessionsManager::processProlong #25 /vendor/magento/module-security/Model/Plugin/AuthSession.php(85): Magento\Security\Model\Plugin\AuthSession::aroundProlong #24 /vendor/magento/framework/Interception/Interceptor.php(135): Magento\Backend\Model\Auth\Session\Interceptor::Magento\Framework\Interception\{closure} #23 /vendor/magento/framework/Interception/Interceptor.php(153): Magento\Backend\Model\Auth\Session\Interceptor::___callPlugins #22 /Magento/Backend/Model/Auth/Session/Interceptor.php(23): Magento\Backend\Model\Auth\Session\Interceptor::prolong #21 /vendor/magento/module-backend/App/Action/Plugin/Authentication.php(127): Magento\Backend\App\Action\Plugin\Authentication::aroundDispatch #20 /vendor/magento/framework/Interception/Interceptor.php(135): Magento\Backend\Controller\Adminhtml\Auth\Login\Interceptor::Magento\Framework\Interception\{closure} #19 /vendor/magento/framework/Interception/Interceptor.php(153): Magento\Backend\Controller\Adminhtml\Auth\Login\Interceptor::___callPlugins #18 /Magento/Backend/Controller/Adminhtml/Auth/Login/Interceptor.php(32): Magento\Backend\Controller\Adminhtml\Auth\Login\Interceptor::dispatch #17 /vendor/magento/framework/App/FrontController.php(245): Magento\Framework\App\FrontController::getActionResponse #16 /vendor/magento/framework/App/FrontController.php(212): Magento\Framework\App\FrontController::processRequest #15 /vendor/magento/framework/App/FrontController.php(147): Magento\Framework\App\FrontController::dispatch #14 /vendor/magento/framework/Interception/Interceptor.php(58): Magento\Framework\App\FrontController\Interceptor::___callParent #13 /vendor/magento/framework/Interception/Interceptor.php(138): Magento\Framework\App\FrontController\Interceptor::Magento\Framework\Interception\{closure} #12 /src/Infortis/ext-magento2-cgen/src/Plugin/Magento/Framework/App/FrontController.php(32): Infortis\Cgen\Plugin\Magento\Framework\App\FrontController::aroundDispatch #11 /vendor/magento/framework/Interception/Interceptor.php(135): Magento\Framework\App\FrontController\Interceptor::Magento\Framework\Interception\{closure} #10 /vendor/magento/framework/Interception/Interceptor.php(153): Magento\Framework\App\FrontController\Interceptor::___callPlugins #9 /Magento/Framework/App/FrontController/Interceptor.php(23): Magento\Framework\App\FrontController\Interceptor::dispatch #8 /vendor/magento/framework/App/Http.php(116): Magento\Framework\App\Http::launch #7 /vendor/magento/framework/Interception/Interceptor.php(58): Magento\Framework\App\Http\Interceptor::___callParent #6 /vendor/magento/framework/Interception/Interceptor.php(138): Magento\Framework\App\Http\Interceptor::Magento\Framework\Interception\{closure} #5 /vendor/justbetter/magento2-sentry/Plugin/GlobalExceptionCatcher.php(58): JustBetter\Sentry\Plugin\GlobalExceptionCatcher::aroundLaunch #4 /vendor/magento/framework/Interception/Interceptor.php(135): Magento\Framework\App\Http\Interceptor::Magento\Framework\Interception\{closure} #3 /vendor/magento/framework/Interception/Interceptor.php(153): Magento\Framework\App\Http\Interceptor::___callPlugins #2 /Magento/Framework/App/Http/Interceptor.php(23): Magento\Framework\App\Http\Interceptor::launch #1 /vendor/magento/framework/App/Bootstrap.php(264): Magento\Framework\App\Bootstrap::run #0 /index.php(29): null ``` --- Please provide [Severity](https://devdocs.magento.com/guides/v2.4/contributor-guide/contributing.html#backlog) assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes. - [ ] Severity: **S0** _- Affects critical data or functionality and leaves users without workaround._ - [x] Severity: **S1** _- Affects critical data or functionality and forces users to employ a workaround._ - [ ] Severity: **S2** _- Affects non-critical data or functionality and forces users to employ a workaround._ - [ ] Severity: **S3** _- Affects non-critical data or functionality and does not force users to employ a workaround._ - [ ] Severity: **S4** _- Affects aesthetics, professional look and feel, “quality” or “usability”._

dmitrii_fediuk · December 10, 2023, 6:44am

The solution

github.com

magento/magento2/blob/2.4.7-beta1/app/code/Magento/Security/Model/AdminSessionInfo.php#L136-L140


      
          if (!is_numeric($lastUpdatedTime)) {
              $lastUpdatedTime = $lastUpdatedTime === null ? 0 : strtotime($lastUpdatedTime);
          }
          
          return $lastUpdatedTime <= ($currentTime - $lifetime);

How did I fix «strtotime() expects parameter 1 to be string, null given in vendor/magento/module-security/Model/AdminSessionInfo.php:136»?

The solution

I use the solution here

1.

2.