Bug: PayPal «Payer Status» and «Merchant Protection Eligibility» payment values on admin order page are untranslatable (and my fix)

dmitry_fedyuk · September 23, 2015, 3:31pm

There are many ways to fix the issue. I propose to change the following line:

magento/magento2/blob/c077da60335dfeb72d9678d519e38d4191170dd9/app/code/Magento/Paypal/Model/Info.php#L571


                $this->_paymentMapFull[$key]['label'] = false;
                $this->_paymentMapFull[$key]['value'] = false;
            } else {
                $value = $payment->getAdditionalInformation($key);
                $this->_paymentMapFull[$key]['label'] = (string)$this->_getLabel($key);
                $this->_paymentMapFull[$key]['value'] = $this->_getValue($value, $key);
            }
        }
        if (!empty($this->_paymentMapFull[$key]['value'])) {
            if ($labelValuesOnly) {
                $result[$this->_paymentMapFull[$key]['label']] = $this->_paymentMapFull[$key]['value'];
            } else {
                $result[$key] = $this->_paymentMapFull[$key];
            }
        }
    }
    return $result;
}


/**
 * Render info item labels

The fix is to call the standard __ function.
Replace the problem line with the new one:

$result[$this->_paymentMapFull[$key]['label']] = __($this->_paymentMapFull[$key]['value']);

It will make all the PayPal payment properties translatable: