\Magento\Integration\Block\Adminhtml\Integration\Edit\Tab\Info::_prepareForm() method does not check whether the $integrationData is null and passes it to methods which expect an array

dmitrii_fediuk · February 26, 2016, 1:12pm

magento/magento2/blob/cf7df72/app/code/Magento/Integration/Block/Adminhtml/Integration/Edit/Tab/Info.php#L40-L56


/**
 * Set form id prefix, declare fields for integration info
 *
 * @return $this
 */
protected function _prepareForm()
{
    /** @var \Magento\Framework\Data\Form $form */
    $form = $this->_formFactory->create();
    $form->setHtmlIdPrefix(self::HTML_ID_PREFIX);
    $integrationData = $this->_coreRegistry->registry(Integration::REGISTRY_KEY_CURRENT_INTEGRATION);
    $this->_addGeneralFieldset($form, $integrationData);
    $this->_addDetailsFieldset($form, $integrationData);
    $form->setValues($integrationData);
    $this->setForm($form);
    return $this;
}

The following expression can return null:

github.com

magento/magento2/blob/cf7df72/app/code/Magento/Integration/Block/Adminhtml/Integration/Edit/Tab/Info.php#L50-L50


$integrationData = $this->_coreRegistry->registry(Integration::REGISTRY_KEY_CURRENT_INTEGRATION);

Then the $integrationData variable is used here:

github.com

magento/magento2/blob/cf7df72/app/code/Magento/Integration/Block/Adminhtml/Integration/Edit/Tab/Info.php#L51-L54


$this->_addGeneralFieldset($form, $integrationData);
$this->_addDetailsFieldset($form, $integrationData);
$form->setValues($integrationData);
$this->setForm($form);

But the called methods expect an array in the place of the $integrationData argument, not null:

github.com

magento/magento2/blob/cf7df72/app/code/Magento/Integration/Block/Adminhtml/Integration/Edit/Tab/Info.php#L98-L105


/**
 * Add fieldset with general integration information.
 *
 * @param \Magento\Framework\Data\Form $form
 * @param array $integrationData
 * @return void
 */
protected function _addGeneralFieldset($form, $integrationData)

github.com

magento/magento2/blob/cf7df72/lib/internal/Magento/Framework/Data/Form.php#L202-L216


/**
 * @param array $values
 * @return $this
 */
public function setValues($values)
{
    foreach ($this->_allElements as $element) {
        if (isset($values[$element->getId()])) {
            $element->setValue($values[$element->getId()]);
        } else {
            $element->setValue(null);
        }
    }
    return $this;
}