Propose to move the \Magento\ImportExport\Model\ResourceModel\Helper::getNextAutoincrement() method to the \Magento\Framework\DB\Adapter\Pdo\Mysql class and to the \Magento\Framework\DB\Adapter\AdapterInterface

dmitry_fedyuk · January 11, 2016, 8:32am

Propose to move the \Magento\ImportExport\Model\ResourceModel\Helper::getNextAutoincrement() method to the \Magento\Framework\DB\Adapter\Pdo\Mysql class and to the \Magento\Framework\DB\Adapter\AdapterInterface interface because the the method is not specific to the Magento_ImportExport module and is useful for external extensions

github.com

magento/magento2/blob/d50ee54/app/code/Magento/ImportExport/Model/ResourceModel/Helper.php#L47-L62


/**
 * Returns next autoincrement value for a table
 *
 * @param string $tableName Real table name in DB
 * @return int
 */
public function getNextAutoincrement($tableName)
{
    $connection = $this->getConnection();
    $entityStatus = $connection->showTableStatus($tableName);


    if (empty($entityStatus['Auto_increment'])) {
        throw new \Magento\Framework\Exception\LocalizedException(__('Cannot get autoincrement value'));
    }
    return $entityStatus['Auto_increment'];
}

dmitry_fedyuk · January 11, 2016, 8:37am