Topics tagged code-quality

Topic	Replies	Views	Activity
Why I do not publish my extensions in Magento Marketplace? Magento Marketplace magento-marketplace , code-quality	0	806	December 15, 2017
Performance issue: Magento 2 generates unnecessary wrappers for all the pluggable methods even there are no plugins for a particular method Issues bug , improvement , performance , code-generation , plugin , code-quality , compilation , interceptor	0	1885	November 14, 2015
Magento 2 duplicates the «\Interceptor» string constant in 9 places Issues improvement , code-quality , code-generation , compilation , interceptor	0	1175	January 1, 2016
The Multishipping::beforeSetShippingMethods() method can be simplified by removing unused $methods argument Issues plugin , plugin-before , improvement , code-quality , multishipping	2	1658	August 28, 2017
The \Magento\Multishipping\Controller\Checkout\Plugin::beforeExecute() method can be simplified by removing unused $subject argument Issues plugin , plugin-before , improvement , code-quality , multishipping	1	2748	August 28, 2017
The Multishipping\Plugin::beforeSave() method can be simplified by removing unused $subject argument Issues plugin , plugin-before , improvement , code-quality , multishipping	1	2343	August 28, 2017
The «Magento\CatalogInventory\Observer\DisplayProductStatusInfoObserver» obverver declaration should be moved from «etc/events.xml» to «etc/frontend/events.xml» because it relies on the «Display products availability in stock on Storefront» config option Issues stock , improvement , code-quality	0	1050	November 13, 2015
The «.less» extension can be skipped in the Less @import statements Development less , improvement , code-quality	0	1210	November 21, 2015
\Magento\Framework\View\Render\RenderFactory::get() unnecessary escapes the slashes Issues improvement , code-quality	0	1039	December 23, 2015
A PHPDoc comment for the $priceModel variable in final_price.phtml is wrong Issues price , improvement , phpdoc , code-quality	0	2199	December 25, 2015
PHPDoc result type is wrong for \Magento\Framework\Data\Form\Element\AbstractElement::addElement() method Issues improvement , phpdoc , code-quality	0	946	November 19, 2015
The \Magento\Catalog\Model\Indexer\Category\AffectCache::beforeExecute() method can be simplified by returning void instead of it's arguments Issues improvement , plugin , plugin-before , code-quality	0	1013	January 7, 2016
The \Magento\Sales\Controller\Order\Plugin\Authentication::beforeDispatch() method can be simplified by removing the unused $request argument Issues plugin , plugin-before , improvement , code-quality	0	1068	January 7, 2016
The \Magento\Tax\Model\Layout\DepersonalizePlugin::beforeGenerateXml() method can be simplified by returning void instead of an array Issues plugin , plugin-before , improvement , code-quality	0	935	January 7, 2016
The \Magento\Tax\Model\Quote\ToOrderConverter::beforeConvert() method can be simplified by returning void instead of an array and removing the unused $additional argument Issues plugin , plugin-before , improvement , code-quality	0	1035	January 7, 2016
The \Magento\Theme\Model\Theme\Plugin\Registration::beforeDispatch() method can be simplified by removing the unused $subject and $request arguments Issues plugin , plugin-before , improvement , code-quality	0	962	January 7, 2016
The MaxHeapTableSizeProcessorOnFullReindex::beforeExecute() method can be simplified by removing unused $subject argument Issues plugin , plugin-before , improvement , code-quality	0	986	January 7, 2016
The Validation::beforeSavePaymentInformationAndPlaceOrder() method can be simplified by removing unused $billingAddress argument Issues plugin , plugin-before , improvement , code-quality	0	1505	January 7, 2016
The Validation::beforeSavePaymentInformation() method can be simplified by removing unused $billingAddress argument Issues plugin , plugin-before , improvement , code-quality	0	1496	January 7, 2016
The Review::beforeGetReviewsSummaryHtml() method can be simplified by removing the unused $templateType and $displayIfNoReviews arguments Issues plugin , plugin-before , improvement , code-quality	0	1131	January 7, 2016
The \Magento\Swatches\Controller\Adminhtml\Product\Attribute\Plugin\Save beforeDispatch() method can be simplified by returning void instead of it's arguments Issues plugin , plugin-before , improvement , code-quality	0	1138	January 7, 2016
The CreateHandler::beforeExecute() method can be simplified by returning void instead of it's arguments Issues plugin , plugin-before , improvement , code-quality	0	1179	January 7, 2016
The \Magento\Customer\Model\Layout\DepersonalizePlugin beforeGenerateXml() method can be simplified by returning void instead of an array Issues plugin , plugin-before , improvement , code-quality	0	1035	January 7, 2016
Propose to add the possibility to set a fieldset-specific renderer to the fieldset elements Issues improvement , form , fieldset , code-quality	0	1055	November 19, 2015
Propose to improve the \Magento\Framework\Data\Form\Element\AbstractElement::setForm() method signature Issues improvement , code-quality	0	985	November 19, 2015
Propose to make the «config» param optional for the \Magento\Framework\Data\Form\AbstractForm::addField() method Issues improvement , code-quality	0	896	December 12, 2015
The constructor of the class \Magento\Framework\View\TemplateEngine\Xhtml\ResultFactory can be shortened by using PHP 5.5 class name resolution via ::class Issues improvement , ::class , code-quality	0	1081	December 14, 2015
Propose to specify the $element parameter class name in the signature of the \Magento\Config\Block\System\Config\Form\Field::_decorateRowHtml() method Issues improvement , code-quality	0	958	December 21, 2015
The Magento_CurrencySymbol module contains not only the «Currency Symbols» functionality but the «Currency Rates» functionality too which is inconsistent with the module name Issues improvement , code-quality	0	885	January 1, 2016
A comment for the «mage.formKey» JavaScript widget is an unterminated sentence: Issues improvement , form-key , jquery-ui-widget , code-quality	0	942	January 26, 2016