The \Magento\Theme\Model\Theme\Plugin\Registration::beforeDispatch() method can be simplified by removing the unused $subject and $request arguments

dmitry_fedyuk · January 7, 2016, 11:01am

magento/magento2/blob/c58d2d/app/code/Magento/Theme/Model/Theme/Plugin/Registration.php#L60-L80


 * Add new theme from filesystem and update existing
 *
 * @param AbstractAction $subject
 * @param RequestInterface $request
 *
 * @return void
 * @SuppressWarnings(PHPMD.UnusedFormalParameter)
 */
public function beforeDispatch(
    AbstractAction $subject,
    RequestInterface $request
) {
    try {
        if ($this->appState->getMode() != AppState::MODE_PRODUCTION) {
            $this->themeRegistration->register();
            $this->updateThemeData();
        }
    } catch (LocalizedException $e) {
        $this->logger->critical($e);
    }
}

This can be simplified to:

/**
 * Add new theme from filesystem and update existing
 *
 * @return void
 */
public function beforeDispatch() {
	try {
		if ($this->appState->getMode() != AppState::MODE_PRODUCTION) {
			$this->themeRegistration->register();
			$this->updateThemeData();
		}
	} catch (LocalizedException $e) {
		$this->logger->critical($e);
	}
}

A trick: a «before» plugin can avoid declaration of unused last arguments if it needs not modify any argument