A trick: a «before» plugin can avoid declaration of unused last arguments if it needs not modify any argument

dmitry_fedyuk (Dmitrii Fediuk) January 7, 2016, 2:25am 1

https://github.com/magento/magento2/blob/c58d2d/lib/internal/Magento/Framework/Interception/Interceptor.php#L118-L126

The call_user_func_array function allows a callee to have less arguments than is passed.
A proof: Online PHP editor | output for lJpkZ

class A {public function test($a) {return $a;}}
echo call_user_func_array([new A, 'test'], [1, 2, 3]);

1

https://github.com/magento/devdocs/issues/516

https://github.com/magento/magento2/issues/3326

The MaxHeapTableSizeProcessorOnFullReindex::beforeExecute() method can be simplified by removing unused $subject argument

The Validation::beforeSavePaymentInformationAndPlaceOrder() method can be simplified by removing unused $billingAddress argument

A trick: a «before» plugin can return nothing if it needs not modify any argument

The Validation::beforeSavePaymentInformation() method can be simplified by removing unused $billingAddress argument

The Multishipping::beforeSetShippingMethods() method can be simplified by removing unused $methods argument

The \Magento\Multishipping\Controller\Checkout\Plugin::beforeExecute() method can be simplified by removing unused $subject argument

The Multishipping\Plugin::beforeSave() method can be simplified by removing unused $subject argument

The Review::beforeGetReviewsSummaryHtml() method can be simplified by removing the unused $templateType and $displayIfNoReviews arguments

The \Magento\Sales\Controller\Order\Plugin\Authentication::beforeDispatch() method can be simplified by removing the unused $request argument

The \Magento\Tax\Model\Quote\ToOrderConverter::beforeConvert() method can be simplified by returning void instead of an array and removing the unused $additional argument

The \Magento\Theme\Model\Theme\Plugin\Registration::beforeDispatch() method can be simplified by removing the unused $subject and $request arguments

The official documentation should state that a «before» plugin could avoid declaration of unused last arguments

dmitry_fedyuk (Dmitrii Fediuk) January 7, 2016, 2:27am 2

See also:

A trick: a «before» plugin can return nothing if it needs not modify any argument