The \Magento\Tax\Model\Quote\ToOrderConverter::beforeConvert() method can be simplified by returning void instead of an array and removing the unused $additional argument

dmitry_fedyuk · January 7, 2016, 10:58am

magento/magento2/blob/c58d2d/app/code/Magento/Tax/Model/Quote/ToOrderConverter.php#L33-L44


/**
 * @param QuoteAddressToOrder $subject
 * @param QuoteAddress $address
 * @param array $additional
 * @return array
 * @SuppressWarnings(PHPMD.UnusedFormalParameter)
 */
public function beforeConvert(QuoteAddressToOrder $subject, QuoteAddress $address, $additional = [])
{
    $this->quoteAddress = $address;
    return [$address, $additional];
}

This can be simplified to:

/**
 * @param QuoteAddressToOrder $subject
 * @param QuoteAddress $address
 * @return void
 */
public function beforeConvert(QuoteAddressToOrder $subject, QuoteAddress $address)
{
	$this->quoteAddress = $address;
}