Topics tagged plugin-before

Topic	Replies	Views	Activity
The Multishipping::beforeSetShippingMethods() method can be simplified by removing unused $methods argument Issues multishipping , plugin-before , improvement , plugin , code-quality	2	1660	August 28, 2017
The \Magento\Multishipping\Controller\Checkout\Plugin::beforeExecute() method can be simplified by removing unused $subject argument Issues multishipping , plugin-before , improvement , plugin , code-quality	1	2759	August 28, 2017
The Multishipping\Plugin::beforeSave() method can be simplified by removing unused $subject argument Issues multishipping , plugin-before , improvement , plugin , code-quality	1	2343	August 28, 2017
The \Magento\Catalog\Model\Indexer\Category\AffectCache::beforeExecute() method can be simplified by returning void instead of it's arguments Issues plugin-before , improvement , plugin , code-quality	0	1016	January 7, 2016
The \Magento\Sales\Controller\Order\Plugin\Authentication::beforeDispatch() method can be simplified by removing the unused $request argument Issues plugin-before , improvement , plugin , code-quality	0	1073	January 7, 2016
The \Magento\Tax\Model\Layout\DepersonalizePlugin::beforeGenerateXml() method can be simplified by returning void instead of an array Issues plugin-before , improvement , plugin , code-quality	0	938	January 7, 2016
The \Magento\Tax\Model\Quote\ToOrderConverter::beforeConvert() method can be simplified by returning void instead of an array and removing the unused $additional argument Issues plugin-before , improvement , plugin , code-quality	0	1037	January 7, 2016
The \Magento\Theme\Model\Theme\Plugin\Registration::beforeDispatch() method can be simplified by removing the unused $subject and $request arguments Issues plugin-before , improvement , plugin , code-quality	0	970	January 7, 2016
The MaxHeapTableSizeProcessorOnFullReindex::beforeExecute() method can be simplified by removing unused $subject argument Issues plugin-before , improvement , plugin , code-quality	0	986	January 7, 2016
The Validation::beforeSavePaymentInformationAndPlaceOrder() method can be simplified by removing unused $billingAddress argument Issues plugin-before , improvement , plugin , code-quality	0	1511	January 7, 2016
The Validation::beforeSavePaymentInformation() method can be simplified by removing unused $billingAddress argument Issues plugin-before , improvement , plugin , code-quality	0	1502	January 7, 2016
The Review::beforeGetReviewsSummaryHtml() method can be simplified by removing the unused $templateType and $displayIfNoReviews arguments Issues plugin-before , improvement , plugin , code-quality	0	1134	January 7, 2016
The \Magento\Swatches\Controller\Adminhtml\Product\Attribute\Plugin\Save beforeDispatch() method can be simplified by returning void instead of it's arguments Issues plugin-before , improvement , plugin , code-quality	0	1140	January 7, 2016
The CreateHandler::beforeExecute() method can be simplified by returning void instead of it's arguments Issues plugin-before , improvement , plugin , code-quality	0	1187	January 7, 2016
The \Magento\Customer\Model\Layout\DepersonalizePlugin beforeGenerateXml() method can be simplified by returning void instead of an array Issues plugin-before , improvement , plugin , code-quality	0	1039	January 7, 2016
The \Magento\Catalog\Model\Indexer\Category\AffectCache and \Magento\Catalog\Model\Indexer\Product\AffectCache have 39 lines of code each but differs by a single constant (copy/paste) Issues plugin-before , improvement , plugin , code-quality	0	933	January 7, 2016
The \Magento\Catalog\Model\Indexer\Product\AffectCache::beforeExecute() method can be simplified by returning void instead of it's arguments Issues plugin-before , improvement , plugin , code-quality	0	1175	January 7, 2016
The official documentation should state that a «before» plugin could return nothing if it needs not modify any argument Issues plugin-before , improvement , plugin , documentation-issue	0	878	January 7, 2016
The official documentation should state that a «before» plugin could avoid declaration of unused last arguments Issues plugin-before , improvement , plugin , documentation-issue	0	777	January 7, 2016
A trick: a «before» plugin can return nothing if it needs not modify any argument Development plugin-before , plugin	1	1984	January 7, 2016
A trick: a «before» plugin can avoid declaration of unused last arguments if it needs not modify any argument Development plugin-before , plugin	1	1666	January 7, 2016