The Multishipping::beforeSetShippingMethods() method can be simplified by removing unused $methods argument

Issues
, , , ,
1

https://github.com/magento/magento2/blob/c58d2d/app/code/Magento/GiftMessage/Model/Type/Plugin/Multishipping.php#L32-L45

This can be simplified to:

/**
 * @param \Magento\Multishipping\Model\Checkout\Type\Multishipping $subject
 * @return void
 */
public function beforeSetShippingMethods(
	\Magento\Multishipping\Model\Checkout\Type\Multishipping $subject
) {
	$giftMessages = $this->request->getParam('giftmessage');
	$quote = $subject->getQuote();
	$this->message->add($giftMessages, $quote);
}

A trick: a «before» plugin can avoid declaration of unused last arguments if it needs not modify any argument

https://github.com/magento/magento2/issues/3348

2

See also:

3