The Review::beforeGetReviewsSummaryHtml() method can be simplified by removing the unused $templateType and $displayIfNoReviews arguments

dmitry_fedyuk · January 7, 2016, 10:41am

magento/magento2/blob/c58d2d/app/code/Magento/Review/Block/Product/Compare/ListCompare/Plugin/Review.php#L37-L57


/**
 * Initialize product review
 *
 * @param \Magento\Catalog\Block\Product\Compare\ListCompare $subject
 * @param \Magento\Catalog\Model\Product $product
 * @param bool $templateType
 * @param bool $displayIfNoReviews
 *
 * @return void
 * @SuppressWarnings(PHPMD.UnusedFormalParameter)
 */
public function beforeGetReviewsSummaryHtml(
    \Magento\Catalog\Block\Product\Compare\ListCompare $subject,
    \Magento\Catalog\Model\Product $product,
    $templateType = false,
    $displayIfNoReviews = false
) {
    if (!$product->getRatingSummary()) {
        $this->reviewFactory->create()->getEntitySummary($product, $this->storeManager->getStore()->getId());
    }
}

This an be simplified to:

/**
 * Initialize product review
 *
 * @param \Magento\Catalog\Block\Product\Compare\ListCompare $subject
 * @param \Magento\Catalog\Model\Product $product
 *
 * @return void
 */
public function beforeGetReviewsSummaryHtml(
	\Magento\Catalog\Block\Product\Compare\ListCompare $subject,
	\Magento\Catalog\Model\Product $product
) {
	if (!$product->getRatingSummary()) {
		$this->reviewFactory->create()->getEntitySummary($product, $this->storeManager->getStore()->getId());
	}
}

A trick: a «before» plugin can avoid declaration of unused last arguments if it needs not modify any argument