The \Magento\Catalog\Model\Indexer\Category\AffectCache::beforeExecute() method can be simplified by returning void instead of it's arguments

dmitry_fedyuk · January 7, 2016, 2:06am

magento/magento2/blob/c58d2d/app/code/Magento/Catalog/Model/Indexer/Category/AffectCache.php#L28-L38


      
          /**
           * @param \Magento\Framework\Indexer\ActionInterface $subject
           * @param array $ids
           * @return array
           * @SuppressWarnings(PHPMD.UnusedFormalParameter)
           */
          public function beforeExecute(\Magento\Framework\Indexer\ActionInterface $subject, $ids)
          {
              $this->context->registerEntities(\Magento\Catalog\Model\Category::CACHE_TAG, $ids);
              return [$ids];
          }

This can be simplified to:

/**
 * @param \Magento\Framework\Indexer\ActionInterface $subject
 * @param array $ids
 * @return void
 * @SuppressWarnings(PHPMD.UnusedFormalParameter)
 */
public function beforeExecute(\Magento\Framework\Indexer\ActionInterface $subject, $ids)
{
	$this->context->registerEntities(\Magento\Catalog\Model\Category::CACHE_TAG, $ids);
}