The MaxHeapTableSizeProcessorOnFullReindex::beforeExecute() method can be simplified by removing unused $subject argument

dmitry_fedyuk · January 7, 2016, 10:05am

magento/magento2/blob/c58d2d/app/code/Magento/Catalog/Plugin/Model/Indexer/Category/Product/MaxHeapTableSizeProcessorOnFullReindex.php#L32-L44


/**
 * @param Full $subject
 * @return void
 * @SuppressWarnings(PHPMD.UnusedFormalParameter)
 */
public function beforeExecute(Full $subject)
{
    try {
        $this->maxHeapTableSizeProcessor->set();
    } catch (\Exception $e) {
        $this->logger->error($e);
    }
}

This can be simplified to:

/**
 * @return void
 */
public function beforeExecute()
{
	try {
		$this->maxHeapTableSizeProcessor->set();
	} catch (\Exception $e) {
		$this->logger->error($e);
	}
}

A trick: a «before» plugin can avoid declaration of unused last arguments if it needs not modify any argument