The method \Magento\Framework\App\Config\ValueInterface::getOldValue() should be removed from the interface because it is used only internally by a particular interface implementation: \Magento\Framework\App\Config\Value

dmitry_fedyuk (Dmitrii Fediuk) January 11, 2016, 12:19pm 1

github.com

magento/magento2/blob/d50ee54/lib/internal/Magento/Framework/App/Config/ValueInterface.php#L24-L29


/**
 * Get old value from existing config
 *
 * @return string
 */
public function getOldValue();

\Magento\Framework\App\Config\Value::afterLoad() method breaks specification of the overriden parent method \Magento\Framework\Model\AbstractModel::afterLoad() by not calling it, ignoring its logic, and having a different result type

None of the \Magento\Framework\App\Config\ValueInterface methods are used by the core outside of the particular implementation \Magento\Framework\App\Config\Value

The method \Magento\Framework\App\Config\ValueInterface::isValueChanged() should be removed from the interface because it is used only internally by a particular interface implementation: \Magento\Framework\App\Config\Value

The methods \Magento\Framework\App\Config\ValueInterface::getFieldsetDataValue() and \Magento\Framework\App\Config\Value::getFieldsetDataValue() are declared but never used

Logical error: Magento 2 checks whether a backend config form field's «backend_model» implements the \Magento\Framework\App\Config\ValueInterface interface only, but actually calls the «backend_model» for much more methods (absent in the interface)

How does Magento 2 save a backend config form vield value?

dmitry_fedyuk (Dmitrii Fediuk) January 11, 2016, 12:21pm 2

See also: