Naming inconsistency: identically named method addCommitCallback() is called BEFORE a commit in the \Magento\Framework\DB\Transaction class, but AFTER a commit in the \Magento\Framework\Model\ResourceModel\AbstractResource class

dmitry_fedyuk · January 27, 2016, 7:48pm

magento/magento2/blob/720667e/lib/internal/Magento/Framework/DB/Transaction.php#L104-L114


/**
 * Add callback function which will be called before commit transactions
 *
 * @param callback $callback
 * @return $this
 */
public function addCommitCallback($callback)
{
    $this->_beforeCommitCallbacks[] = $callback;
    return $this;
}

github.com

magento/magento2/blob/720667e/lib/internal/Magento/Framework/DB/Transaction.php#L135-L148


if ($error === false) {
    try {
        $this->_runCallbacks();
    } catch (\Exception $e) {
        $error = $e;
    }
}


if ($error) {
    $this->_rollbackTransaction();
    throw $error;
} else {
    $this->_commitTransaction();
}

github.com

magento/magento2/blob/720667e/lib/internal/Magento/Framework/Model/ResourceModel/AbstractResource.php#L61-L73


/**
 * Subscribe some callback to transaction commit
 *
 * @param array $callback
 * @return $this
 * @api
 */
public function addCommitCallback($callback)
{
    $connectionKey = spl_object_hash($this->getConnection());
    self::$_commitCallbacks[$connectionKey][] = $callback;
    return $this;
}

github.com

magento/magento2/blob/720667e/lib/internal/Magento/Framework/Model/ResourceModel/AbstractResource.php#L83-L101


$this->getConnection()->commit();
/**
 * Process after commit callbacks
 */
if ($this->getConnection()->getTransactionLevel() === 0) {
    $connectionKey = spl_object_hash($this->getConnection());
    if (isset(self::$_commitCallbacks[$connectionKey])) {
        $callbacks = self::$_commitCallbacks[$connectionKey];
        self::$_commitCallbacks[$connectionKey] = [];
        try {
            foreach ($callbacks as $callback) {
                call_user_func($callback);
            }
        } catch (\Exception $e) {
            echo $e;
            throw $e;
        }
    }
}