The \Magento\Payment\Model\Method\AbstractMethod::getConfigData() method has a wrong PHPDoc type for the $storeId parameter

dmitrii_fediuk · February 8, 2016, 10:16pm

magento/magento2/blob/6ce74b2/app/code/Magento/Payment/Model/Method/AbstractMethod.php#L742-L760


/**
 * Retrieve information from payment configuration
 *
 * @param string $field
 * @param int|string|null|\Magento\Store\Model\Store $storeId
 *
 * @return mixed
 */
public function getConfigData($field, $storeId = null)
{
    if ('order_place_redirect_url' === $field) {
        return $this->getOrderPlaceRedirectUrl();
    }
    if (null === $storeId) {
        $storeId = $this->getStore();
    }
    $path = 'payment/' . $this->getCode() . '/' . $field;
    return $this->_scopeConfig->getValue($path, \Magento\Store\Model\ScopeInterface::SCOPE_STORE, $storeId);
}

Should be:

@param null|string|int|\Magento\Framework\App\ScopeInterface $storeId [optional]

dmitrii_fediuk · February 8, 2016, 10:16pm