The XML config nodes `default\payment\<payment method>\active` with the «0» value are unnecessary and can be deleted without any impact on the system behaviour

dmitry_fedyuk · February 8, 2016, 10:39pm

The \Magento\Payment\Model\Method\AbstractMethod::isActive() method returns false whenever <active> node contains 0 or there is no <active> node at all, so all the default\payment\<payment method>\active nodes with the 0 value could be dropped:

github.com

magento/magento2/blob/6ce74b2/app/code/Magento/Payment/Model/Method/AbstractMethod.php#L827-L836


/**
 * Is active
 *
 * @param int|null $storeId
 * @return bool
 */
public function isActive($storeId = null)
{
    return (bool)(int)$this->getConfigData('active', $storeId);
}

github.com

magento/magento2/blob/6ce74b2/app/code/Magento/Braintree/etc/config.xml#L11-L15


<braintree>
    <model>Magento\Braintree\Model\PaymentMethod</model>
    <title>Credit Card (Braintree)</title>
    <payment_action>authorize</payment_action>
    <active>0</active>

github.com

magento/magento2/blob/6ce74b2/app/code/Magento/Braintree/etc/config.xml#L32-L36


<braintree_paypal>
    <model>Magento\Braintree\Model\PaymentMethod\PayPal</model>
    <title>PayPal (Braintree)</title>
    <payment_action>authorize</payment_action>
    <active>0</active>

github.com

magento/magento2/blob/6ce74b2/app/code/Magento/BraintreeTwo/etc/config.xml#L11-L15


<braintreetwo>
    <model>BraintreeTwoFacade</model>
    <title>Credit Card (BraintreeTwo)</title>
    <payment_action>authorize</payment_action>
    <active>0</active>