The method \Magento\Payment\Model\Method\AbstractMethod::canUseForCountry() can be simplified

dmitry_fedyuk · February 11, 2016, 2:19am

magento/magento2/blob/6ce74b2/app/code/Magento/Payment/Model/Method/AbstractMethod.php#L464-L482


/**
 * To check billing country is allowed for the payment method
 *
 * @param string $country
 * @return bool
 */
public function canUseForCountry($country)
{
    /*
    for specific country, the flag will set up as 1
    */
    if ($this->getConfigData('allowspecific') == 1) {
        $availableCountries = explode(',', $this->getConfigData('specificcountry'));
        if (!in_array($country, $availableCountries)) {
            return false;
        }
    }
    return true;
}

It can be simplified to:

public function canUseForCountry($country)
{
    return !$this->getConfigData('allowspecific')
	   || in_array($country, explode(',', $this->getConfigData('specificcountry')));
}