The \Magento\Payment\Helper\Data::getStoreMethods() method has a wrong PHPDoc type for the $methodInstance variable

dmitrii_fediuk · February 12, 2016, 3:03am

magento/magento2/blob/6ce74b2/app/code/Magento/Payment/Helper/Data.php#L137-L138


/** @var AbstractMethod $methodInstance */
$methodInstance = $this->_methodFactory->create($model);

Should be

/** @var \Magento\Payment\Model\MethodInterface $methodInstance */

github.com

magento/magento2/blob/6ce74b2/app/code/Magento/Payment/Model/Method/Factory.php#L30-L47


/**
 * Creates new instances of payment method models
 *
 * @param string $className
 * @param array $data
 * @return \Magento\Payment\Model\MethodInterface
 * @throws \Magento\Framework\Exception\LocalizedException
 */
public function create($className, $data = [])
{
    $method = $this->_objectManager->create($className, $data);
    if (!$method instanceof \Magento\Payment\Model\MethodInterface) {
        throw new \Magento\Framework\Exception\LocalizedException(
            __('%1 class doesn\'t implement \Magento\Payment\Model\MethodInterface', $className)
        );
    }
    return $method;
}