The getControllerName() function of the Magento/Braintree/view/frontend/web/js/view/payment/method-renderer/cc-form.js always returns «undefined» and therefore has no sense

dmitrii_fediuk · February 29, 2016, 1:19am

Definition

magento/magento2/blob/cf7df72/app/code/Magento/Braintree/view/frontend/web/js/view/payment/method-renderer/cc-form.js#L66-L71


/**
 * @returns {*}
 */
getControllerName: function () {
    return window.checkoutConfig.payment.iframe.controllerName[this.getCode()];
},

Usage

github.com

magento/magento2/blob/cf7df72/app/code/Magento/Braintree/view/frontend/web/template/payment/cc-form.html#L31-L37


<form class="form" id="co-transparent-form" action="#" method="post" data-bind="mageInit: {
    'transparent':{
        'context': context(),
        'gateway': getCode(),
        'controller': getControllerName(),
        'orderSaveUrl':getPlaceOrderUrl(),
    }, 'validation':[]}">

Why does it always return `undefined`?

The window.checkoutConfig.payment.iframe config branch is initialized only by the \Magento\Payment\Model\IframeConfigProvider:

github.com

magento/magento2/blob/cf7df72/app/code/Magento/Payment/Model/IframeConfigProvider.php#L98-L115


public function getConfig()
{
    return [
        'payment' => [
            'iframe' => [
                'timeoutTime' => [$this->methodCode => self::TIMEOUT_TIME],
                'dateDelim' => [$this->methodCode => $this->getDateDelim()],
                'cardFieldsMap' => [$this->methodCode => $this->getCardFieldsMap()],
                'source' =>  [$this->methodCode => $this->getViewFileUrl('blank.html')],
                'controllerName' => [$this->methodCode => self::CHECKOUT_IDENTIFIER],
                'cgiUrl' => [$this->methodCode => $this->getCgiUrl()],
                'placeOrderUrl' => [$this->methodCode => $this->getPlaceOrderUrl()],
                'saveOrderUrl' => [$this->methodCode => $this->getSaveOrderUrl()],
                'expireYearLength' => [$this->methodCode => $this->getExpireDateYearLength()]
            ]
        ]
    ];
}

But the Magento_Braintree's configuration providers are not descendants of the [\Magento\Payment\Model\IframeConfigProvider:

github.com

magento/magento2/blob/cf7df72/app/code/Magento/Braintree/etc/frontend/di.xml#L16-L23


<type name="Magento\Checkout\Model\CompositeConfigProvider">
    <arguments>
        <argument name="configProviders" xsi:type="array">
            <item name="braintree_config_provider" xsi:type="object">Magento\Braintree\Model\ConfigProvider</item>
            <item name="braintree_paypal_config_provider" xsi:type="object">Magento\Braintree\Model\ConfigProvider\PayPal</item>
        </argument>
    </arguments>
</type>

github.com

magento/magento2/blob/cf7df72/app/code/Magento/Braintree/Model/ConfigProvider.php#L13-L13


class ConfigProvider extends CcGenericConfigProvider

github.com

magento/magento2/blob/cf7df72/app/code/Magento/Payment/Model/CcGenericConfigProvider.php#L11-L11


class CcGenericConfigProvider implements ConfigProviderInterface

github.com

magento/magento2/blob/cf7df72/app/code/Magento/Braintree/Model/ConfigProvider/PayPal.php#L12-L12


class PayPal implements ConfigProviderInterface

dmitrii_fediuk · February 29, 2016, 1:36am

Definition

Usage

Why does it always return undefined?

Why does it always return `undefined`?