The method \Magento\Payment\Model\CcGenericConfigProvider::getCcAvailableTypes() can be simplified

dmitry_fedyuk · March 1, 2016, 2:46am

magento/magento2/blob/cf7df72/app/code/Magento/Payment/Model/CcGenericConfigProvider.php#L105-L124


/**
 * Retrieve availables credit card types
 *
 * @param string $methodCode
 * @return array
 */
protected function getCcAvailableTypes($methodCode)
{
    $types = $this->ccConfig->getCcAvailableTypes();
    $availableTypes = $this->methods[$methodCode]->getConfigData('cctypes');
    if ($availableTypes) {
        $availableTypes = explode(',', $availableTypes);
        foreach (array_keys($types) as $code) {
            if (!in_array($code, $availableTypes)) {
                unset($types[$code]);
            }
        }
    }
    return $types;
}

The following block can be simplified:

github.com

magento/magento2/blob/cf7df72/app/code/Magento/Payment/Model/CcGenericConfigProvider.php#L117-L121


foreach (array_keys($types) as $code) {
    if (!in_array($code, $availableTypes)) {
        unset($types[$code]);
    }
}

$types = array_intersect_key($types, array_flip($availableTypes));

dmitry_fedyuk · March 1, 2016, 2:50am