The \Magento\Payment\Model\Checks\ZeroTotal::isApplicable() method can be simplified

dmitry_fedyuk · March 5, 2016, 3:00am

magento/magento2/blob/cf7df72/app/code/Magento/Payment/Model/Checks/ZeroTotal.php#L13-L24


/**
 * Check whether payment method is applicable to quote
 * Purposed to allow use in controllers some logic that was implemented in blocks only before
 *
 * @param MethodInterface $paymentMethod
 * @param \Magento\Quote\Model\Quote $quote
 * @return bool
 */
public function isApplicable(MethodInterface $paymentMethod, Quote $quote)
{
    return !($quote->getBaseGrandTotal() < 0.0001 && $paymentMethod->getCode() != 'free');
}

It can be simplified to:

return $quote->getBaseGrandTotal() >= 0.0001 || $paymentMethod->getCode() == 'free';