How are the methods setBaseAdjustmentPositive(), getBaseAdjustmentPositive(), setBaseAdjustmentNegative(), getBaseAdjustmentNegative() of the \Magento\Sales\Model\Order\Creditmemo class used?

Development Payment

dmitry_fedyuk (Dmitrii Fediuk) March 17, 2016, 5:32pm 1

Implementation

https://github.com/magento/magento2/blob/2.0.0/app/code/Magento/Sales/Api/Data/CreditmemoInterface.php#L112-L115

https://github.com/magento/magento2/blob/2.0.0/app/code/Magento/Sales/Api/Data/CreditmemoInterface.php#L56-L59

setBaseAdjustmentPositive()

https://github.com/magento/magento2/blob/2.0.0/app/code/Magento/Sales/Model/Order/Creditmemo.php#L746-L755

setBaseAdjustmentNegative()

https://github.com/magento/magento2/blob/2.0.0/app/code/Magento/Sales/Model/Order/Creditmemo.php#L725-L734

getBaseAdjustmentPositive()

https://github.com/magento/magento2/blob/2.0.0/app/code/Magento/Sales/Model/Order/Creditmemo.php#L736-L744

getBaseAdjustmentNegative()

https://github.com/magento/magento2/blob/2.0.0/app/code/Magento/Sales/Model/Order/Creditmemo.php#L715-L723

Usage

1

Bug: the setAdjustmentPositive() and setAdjustmentNegative() methods of the \Magento\Sales\Model\Order\Creditmemo class wrongly use the \Magento\Sales\Model\Order's getGrandTotal() method instead of the getBaseGrandTotal() when an adjusment is in percent, so it lead to a wrong calculation result

https://github.com/magento/magento2/blob/2.0.0/app/code/Magento/Sales/Model/Order/Creditmemo.php#L489-L507

2

https://github.com/magento/magento2/blob/2.0.0/app/code/Magento/Sales/Block/Adminhtml/Order/Creditmemo/Totals.php#L58-L78

3

https://github.com/magento/magento2/blob/2.0.0/app/code/Magento/Sales/Model/Order/Creditmemo/Total/Grand.php#L14-L34

4

https://github.com/magento/magento2/blob/2.0.0/app/code/Magento/Sales/Model/ResourceModel/Order/Creditmemo/Relation/Refund.php#L67-L73

https://github.com/magento/magento2/blob/2.0.0/app/code/Magento/Sales/Model/ResourceModel/Order/Creditmemo/Relation/Refund.php#L105-L113

What is an «Adjustment Fee» for a credit memo?

What is an «Adjustment Refund» for a credit memo?

How are the methods setAdjustmentPositive(), getAdjustmentPositive(), setAdjustmentNegative(), getAdjustmentNegative() of the \Magento\Sales\Model\Order\Creditmemo class used?

How are the methods setAdjustmentPositive(), getAdjustmentPositive(), setAdjustmentNegative(), getAdjustmentNegative() of the \Magento\Sales\Model\Order class used?

How are the methods setBaseAdjustmentPositive(), getBaseAdjustmentPositive(), setBaseAdjustmentNegative(), getBaseAdjustmentNegative() of the \Magento\Sales\Model\Order class used?

Bug: the setAdjustmentPositive() and setAdjustmentNegative() methods of the Creditmemo class wrongly use the Order's getGrandTotal() method instead of the getBaseGrandTotal() when an adjusment is in percent, so it lead to a wrong calculation result

dmitry_fedyuk (Dmitrii Fediuk) March 17, 2016, 5:46pm 2

See also: