What is an «Adjustment Refund» for a credit memo?

dmitrii_fediuk · March 17, 2016, 2:48pm

magento/magento2/blob/2.1.3/app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/create/totals/adjustments.phtml#L23-L30


      
          <td class="label"><?php /* @escapeNotVerified */ echo __('Adjustment Refund') ?><div id="adjustment_positive_adv"></div></td>
          <td>
              <input type="text"
                     name="creditmemo[adjustment_positive]"
                     value="<?php /* @escapeNotVerified */ echo $_source->getBaseAdjustmentFeePositive()*1 ?>"
                     class="input-text admin__control-text not-negative-amount"
                     id="adjustment_positive" />
          </td>

An «Adjustment Refund» value will be added to the total credit memo (refund) amount.
An «Adjustment Refund» value should be non-negative:

github.com

magento/magento2/blob/2.1.3/app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/create/totals/adjustments.phtml#L44-L51


      
          Validation.addAllThese([
              ['not-negative-amount', '<?php /* @escapeNotVerified */ echo __('Please enter a positive number in this field.') ?>', function(v) {
                  if(v.length)
                      return /^\s*\d+([,.]\d+)*\s*%?\s*$/.test(v);
                  else
                      return true;
              }]
          ]);

The value can be in percents (it should ends with the percent sign in this case):

github.com

magento/magento2/blob/2.1.3/app/code/Magento/Sales/Model/Order/Creditmemo.php#L495-L498


      
          if (substr($amount, -1) == '%') {
              $amount = (double)substr($amount, 0, -1);
              $amount = $this->getOrder()->getGrandTotal() * $amount / 100;
          }

Bug: the setAdjustmentPositive() and setAdjustmentNegative() methods of the \Magento\Sales\Model\Order\Creditmemo class wrongly use the \Magento\Sales\Model\Order’s getGrandTotal() method instead of the getBaseGrandTotal() when an adjusment is in percent, so it lead to a wrong calculation result

Take example your customer bought 2 chocolate each costing $5. However he/she wants to return one. In that case you have to return $5 which is correct mathematically (and this is what default magneto calculation shows you). But, you can change mind as business man, like

If you feel to giving return $6, write $1 in Adjustment Refund.
If you feel to give return $4, write $1 in Adjustment Fee.

Unable to generate Credit Memo in magento - Stack Overflow](Unable to generate Credit Memo in magento - Stack Overflow)

dmitrii_fediuk · March 17, 2016, 2:49pm