A logical expression in the \Magento\Sales\Block\Adminhtml\Items\AbstractItems::canEditQty() method can be simplified

dmitry_fedyuk (Dmitrii Fediuk) February 9, 2016, 5:16am 1

github.com

magento/magento2/blob/6ce74b2/app/code/Magento/Sales/Block/Adminhtml/Items/AbstractItems.php#L409-L412


if ($this->getOrder()->getPayment()->canCapture()) {
    return $this->getOrder()->getPayment()->canCapturePartial();
}
return true;

It can be simplified to:

return !$this->getOrder()->getPayment()->canCapture() || $this->getOrder()->getPayment()->canCapturePartial();

The method \Magento\Sales\Block\Adminhtml\Order\Invoice\Create\Items::canEditQty() can be simplified

dmitry_fedyuk (Dmitrii Fediuk) February 9, 2016, 5:23am 2

See also:

The method \Magento\Sales\Block\Adminhtml\Order\Invoice\Create\Items::canEditQty() can be simplified