The method \Magento\Sales\Block\Adminhtml\Order\Invoice\Create\Items::canEditQty() can be simplified

dmitry_fedyuk · February 9, 2016, 5:21am

magento/magento2/blob/6ce74b2/app/code/Magento/Sales/Block/Adminhtml/Order/Invoice/Create/Items.php#L206-L217


/**
 * Check if qty can be edited
 *
 * @return bool
 */
public function canEditQty()
{
    if ($this->getInvoice()->getOrder()->getPayment()->canCapture()) {
        return $this->getInvoice()->getOrder()->getPayment()->canCapturePartial();
    }
    return true;
}

It can be simplified to:

public function canEditQty()
{
    return !$this->getInvoice()->getOrder()->getPayment()->canCapture() 
	   || $this->getInvoice()->getOrder()->getPayment()->canCapturePartial();
}

dmitry_fedyuk · February 9, 2016, 5:22am