Topics tagged code-quality

Topic	Replies	Views	Activity
The method \Magento\Framework\App\Config\ValueInterface::isValueChanged() should be removed from the interface because it is used only internally by a particular interface implementation: \Magento\Framework\App\Config\Value Issues backend_model , config-field , improvement , code-quality	1	1239	January 11, 2016
The method \Magento\Framework\App\Config\ValueInterface::getOldValue() should be removed from the interface because it is used only internally by a particular interface implementation: \Magento\Framework\App\Config\Value Issues backend_model , config-field , improvement , code-quality	1	1153	January 11, 2016
Propose to move the \Magento\ImportExport\Model\ResourceModel\Helper::getNextAutoincrement() method to the \Magento\Framework\DB\Adapter\Pdo\Mysql class and to the \Magento\Framework\DB\Adapter\AdapterInterface Issues sql , database , db-table-increment , mysql , improvement , code-quality	1	1217	January 11, 2016
Propose to make the \Magento\SalesSequence\Model\Sequence::calculateCurrentValue() method protected instead of private, so to allow the subclasses to modify it Issues sales , sales-documents-numeration , sales-document , improvement , code-quality	1	1152	January 11, 2016
The PHPDoc return type of the \Magento\SalesSequence\Model\Sequence::calculateCurrentValue() method should be int, not string Issues sales , sales-documents-numeration , sales-document , improvement , phpdoc , code-quality	1	1274	January 11, 2016
The Multishipping::beforeSetShippingMethods() method has a wrong PHPDoc return type Issues improvement , phpdoc , code-quality	1	1320	January 7, 2016
A PHPDoc result type of the \Magento\Framework\View\TemplateEngineInterface::render() method is wrong Issues template , improvement , phpdoc , code-quality	1	1186	January 4, 2016
A PHPDoc result type of the \Magento\Framework\View\Element\UiComponent\ContentType\Html::render() method is wrong UI Components template , improvement , ui-component , phpdoc , code-quality	1	1855	January 4, 2016
The \Magento\Framework\App\Config\ScopePool::_getScopeCode() method has a wrong PHPDoc type for the $scopeCode parameter Issues scope , improvement , config-value , phpdoc , code-quality	1	1395	December 26, 2015
Propose to make the \Magento\Framework\App\Config\ScopePool::_getScopeCode() public because it is useful to calculate cache keys based on a scope (like \Magento\Framework\App\Config\ScopePool::getScope() does) Issues scope , improvement , config-value , code-quality	1	1365	December 26, 2015
\Magento\MediaStorage\Model\File\Storage\Synchronization::synchronize() contains a wrong PHPDoc comment for the $file variable Issues media , filesystem , improvement , phpdoc , code-quality	1	1256	November 29, 2015
\Magento\MediaStorage\Model\File\Storage\Synchronization::synchronize() suppresses its exceptions for a questionably reason Issues media , filesystem , improvement , code-quality	1	1498	November 29, 2015
\Magento\MediaStorage\Model\File\Storage\Synchronization::synchronize() duplicates the code in the try and catch blocks, propose to use a «finally» block Issues media , filesystem , improvement , code-quality	1	1428	November 29, 2015
The \Magento\Framework\Filesystem\Directory\Read::readFile() method should firsly check whether the $path argument is empty string and raise an exception with a proper and clear message in this case instead of the current cryptic message Issues improvement , code-quality	1	3457	November 23, 2015