Topics tagged code-quality

Topic	Replies	Views	Activity
The «captcha» backend observer for the «controller_action_predispatch_customer_account_forgotpasswordpost» event has no sense Issues improvement , captcha , observer , event , password , password-reset , customer , code-quality	1	1298	March 4, 2016
The collectTypes() method from the Magento_BraintreeTwo's validator.js can be simplified from 8 lines to 1 Issues improvement , payment , braintree , javascript , underscore-js , code-quality	1	952	February 27, 2016
The collectTypes() method from the Magento_Braintree's cc-form.js can be simplified from 8 lines to 1 Issues improvement , underscore-js , javascript , braintree , payment , code-quality	1	1037	February 27, 2016
The method \Magento\Payment\Model\CcGenericConfigProvider::getCcAvailableTypes() can be simplified Issues payment , checkout-config-provider , improvement , bank-card , code-quality	1	1474	March 1, 2016
The property \Magento\Braintree\Model\ConfigProvider::$methodCodes is never used Issues improvement , braintree , payment , checkout-config-provider , unused , code-quality	1	1111	February 29, 2016
The property \Magento\Braintree\Model\ConfigProvider\PayPal::$methodCodes is never used Issues braintree , paypal , payment , improvement , checkout-config-provider , unused , code-quality	1	1008	February 29, 2016
The getSource() function of the Magento/Braintree/view/frontend/web/js/view/payment/method-renderer/cc-form.js is never used Issues ui-component , javascript , checkout , braintree , payment , improvement , unused , code-quality	1	1081	February 29, 2016
The getPlaceOrderUrl() function of the Magento/Braintree/view/frontend/web/js/view/payment/method-renderer/cc-form.js always returns «undefined» and therefore has no sense Issues ui-component , javascript , checkout , payment , braintree , improvement , checkout-config-provider , code-quality	1	1474	February 29, 2016
The getSource() function of the Magento/Braintree/view/frontend/web/js/view/payment/method-renderer/cc-form.js always returns «undefined» and therefore has no sense Issues ui-component , javascript , checkout , payment , braintree , improvement , checkout-config-provider , code-quality	1	1635	February 29, 2016
The getControllerName() function of the Magento/Braintree/view/frontend/web/js/view/payment/method-renderer/cc-form.js always returns «undefined» and therefore has no sense Issues improvement , braintree , payment , checkout , javascript , ui-component , checkout-config-provider , code-quality	1	1456	February 29, 2016
The Magento_Braintree's view/frontend/templates/form.phtml template is never used Issues braintree , payment , improvement , unused , code-quality	1	1052	February 28, 2016
Magento_Braintree's view/frontend/web/js/cc-form.js script is never used Issues improvement , payment , database , braintree , unused , code-quality	1	1116	February 29, 2016
The collectTypes() method is duplicated in the Magento_Braintree's cc-form.js and Magento_BraintreeTwo's validator.js Issues improvement , braintree , payment , javascript , code-quality	1	1049	February 27, 2016
The \Magento\Framework\App\Config::getValue() method has a wrong PHPDoc type for the $scopeCode parameter Issues config-value , improvement , scope , phpdoc , configuration , code-quality	1	1739	December 26, 2015
The \Magento\Payment\Model\Method\AbstractMethod::assignData() method can be simplified Issues improvement , payment , payment-method-interface , code-quality	1	1153	February 15, 2016
The \Magento\Payment\Model\Method\AbstractMethod::assignData() method has a wrong PHPDoc declaration Issues improvement , phpdoc , payment , payment-method-interface , code-quality	1	1188	February 15, 2016
The \Magento\Payment\Model\Method\AbstractMethod::getConfigData() method has a wrong PHPDoc type for the $storeId parameter Issues improvement , phpdoc , payment , code-quality	1	1202	February 8, 2016
The \Magento\Payment\Model\MethodInterface::getConfigData() method has a wrong PHPDoc type for the $storeId parameter Issues improvement , phpdoc , payment , code-quality	1	1226	February 8, 2016
The method \Magento\Vault\Model\Method\Vault::canCaptureOnce() is never used Vault vault , payment , improvement , payment-capture , unused , code-quality	1	1175	February 10, 2016
A logical expression in the \Magento\Sales\Block\Adminhtml\Items\AbstractItems::canEditQty() method can be simplified Issues improvement , code-quality	1	799	February 9, 2016
The method \Magento\Sales\Block\Adminhtml\Order\Invoice\Create\Items::canEditQty() can be simplified Issues improvement , code-quality	1	860	February 9, 2016
The method isActive() should be removed from the interface \Magento\Payment\Model\MethodInterface, because it is used only by a particular interface's implementation \Magento\Payment\Model\Method\AbstractMethod and by vault payment methods Issues improvement , payment , payment-method-interface , vault , code-quality	1	1148	February 9, 2016
The method canOrder() should be removed from the interface \Magento\Payment\Model\MethodInterface, because it is not used outside of a particular interface's implementation \Magento\Payment\Model\Method\AbstractMethod Issues improvement , payment , payment-method-interface , code-quality	1	1081	February 9, 2016
The method canAuthorize() should be removed from the interface \Magento\Payment\Model\MethodInterface, because it is used only by a particular interface's implementation \Magento\Payment\Model\Method\AbstractMethod and by vault payment methods Issues improvement , payment , payment-method-interface , vault , payment-authorization , code-quality	1	1126	February 9, 2016
The \Magento\Payment\Model\MethodInterface::isActive() method has a wrong PHPDoc type for the $storeId parameter Issues improvement , phpdoc , payment , code-quality	1	1015	February 8, 2016
The \Magento\Payment\Model\Method\AbstractMethod::isActive() method has a wrong PHPDoc type for the $storeId parameter Issues improvement , phpdoc , payment , code-quality	1	1025	February 8, 2016
The \Magento\Quote\Setup\UpgradeSchema::upgrade() method can be simplified by using the modifyColumn() instead of changeColumn() method of the \Magento\Framework\DB\Adapter\AdapterInterface because the column need not be renamed Issues improvement , database , sql , db-table , db-alter-table , db-column , code-quality	1	1318	January 26, 2016
The message «The image cannot be removed as it has been assigned to the other image role» is unclear because it does not say what exactly the administrator should to do to remove the problem image Issues backend-product-view , image , improvement , code-quality	1	3342	January 25, 2016
Logical error: Magento 2 checks whether a backend config form field's «backend_model» implements the \Magento\Framework\App\Config\ValueInterface interface only, but actually calls the «backend_model» for much more methods (absent in the interface) Issues backend_model , config-field , improvement , code-quality	1	1989	January 11, 2016
The methods \Magento\Framework\App\Config\ValueInterface::getFieldsetDataValue() and \Magento\Framework\App\Config\Value::getFieldsetDataValue() are declared but never used Issues backend_model , config-field , improvement , unused , code-quality	1	1459	January 11, 2016